Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753341AbeAEXqz (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Fri, 5 Jan 2018 18:46:55 -0500
Received: from mga09.intel.com ([134.134.136.24]:8958 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753287AbeAEXqx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 Jan 2018 18:46:53 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,320,1511856000"; 
   d="scan'208";a="192772683"
Message-ID: <1515196012.26317.52.camel@linux.intel.com>
Subject: Re: [PATCH] tools/power/x86/intel_pstate_tracer: Free the trace
 buffer memory
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
        Doug Smythies <doug.smythies@gmail.com>
Cc: Doug Smythies <dsmythies@telus.net>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>
Date: Fri, 05 Jan 2018 15:46:52 -0800
In-Reply-To: <CAJZ5v0hvFrfRR8PEQgUgEh3r1NnH5r26fxzc=Kc+k9D8rDp+Lw@mail.gmail.com>
References: <1515191476-3424-1-git-send-email-dsmythies@telus.net>
         <CAJZ5v0hvFrfRR8PEQgUgEh3r1NnH5r26fxzc=Kc+k9D8rDp+Lw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Fri, 2018-01-05 at 23:54 +0100, Rafael J. Wysocki wrote:
> On Fri, Jan 5, 2018 at 11:31 PM, Doug Smythies <doug.smythies@gmail.c
> om> wrote:
> > 
> > The trace buffer memory should be, mostly, freed after
> > the buffer has been output.
> > 
> > This patch is required before a future patch that will allow
> > the user to override the default, and specify the trace buffer
> > memory allocation as a command line option.
> > 
> > Signed-off-by: Doug Smythies <dsmythies@telus.net>
> Looks OK to me.  Srinivas?

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> 
> > 
> > ---
> >  .../power/x86/intel_pstate_tracer/intel_pstate_tracer.py  | 15
> > +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git
> > a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> > b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> > index 0b24dd9..29f50d4 100755
> > --- a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> > +++ b/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py
> > @@ -411,6 +411,16 @@ def set_trace_buffer_size():
> >          print('IO error setting trace buffer size ')
> >          quit()
> > 
> > +def free_trace_buffer():
> > +    """ Free the trace buffer memory """
> > +
> > +    try:
> > +       open('/sys/kernel/debug/tracing/buffer_size_kb'
> > +                 , 'w').write("1")
> > +    except:
> > +        print('IO error setting trace buffer size ')
> > +        quit()
> > +
> >  def read_trace_data(filename):
> >      """ Read and parse trace data """
> > 
> > @@ -583,4 +593,9 @@ for root, dirs, files in os.walk('.'):
> >      for f in files:
> >          fix_ownership(f)
> > 
> > +clear_trace_file()
> > +# Free the memory
> > +if interval:
> > +    free_trace_buffer()
> > +
> >  os.chdir('../../')
> > --
> > 2.7.4
> >