Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752298AbeAFGIR (ORCPT + 1 other); Sat, 6 Jan 2018 01:08:17 -0500 Received: from mga04.intel.com ([192.55.52.120]:39438 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbeAFGIQ (ORCPT ); Sat, 6 Jan 2018 01:08:16 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,320,1511856000"; d="scan'208";a="8992393" Date: Sat, 6 Jan 2018 11:42:23 +0530 From: Vinod Koul To: Pierre-Louis Bossart Cc: Mark Brown , ALSA , Charles Keepax , Sudheer Papothi , Takashi , Greg Kroah-Hartman , plai@codeaurora.org, LKML , patches.audio@intel.com, srinivas.kandagatla@linaro.org, Sagar Dharia , alan@linux.intel.com Subject: Re: [alsa-devel] [PATCH v6 07/14] regmap: Add SoundWire bus support Message-ID: <20180106061223.GP18649@localhost> References: <1513230585-13882-1-git-send-email-vinod.koul@intel.com> <1513230585-13882-8-git-send-email-vinod.koul@intel.com> <20180105170421.GE9076@sirena.org.uk> <98480de5-cd6b-845f-df1d-c9593596055f@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98480de5-cd6b-845f-df1d-c9593596055f@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Jan 05, 2018 at 11:22:15AM -0600, Pierre-Louis Bossart wrote: > On 1/5/18 11:04 AM, Mark Brown wrote: > >On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote: > > > >>+ /* SoundWire register address are contiguous */ > >>+ if (config->reg_stride != 0) > >>+ return -ENOTSUPP; > > > >That doesn't mean the chip hasn't decided not to use half the addresses > >for some reason - this isn't something the bus should be enforcing. > > Good point. The contiguous requirement is valid only for normative > registers, where the device has no choice but to follow the standard. For > the imp-def part where regmap would typically be used, then indeed there is > no restriction, chip implementers can do whatever they want. > I have a vague memory that regmap was only intended to be used for this > latter case, but Vinod and team should clarify this. Right now it is used by codec for imp-def area. We do plan to add for all registers eventually Thanks -- ~Vinod