Date: Sat, 6 Jan 2018 09:55:38 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        David Woodhouse <dwmw@amazon.co.uk>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 8/8] x86: Use IBRS for firmware update path
Message-ID: <20180106085538.GB4380@kroah.com>
References: <cover.1515204614.git.tim.c.chen@linux.intel.com>
 <cda39b693d0fec41bd65aa17e7d7ea6bcbf48cc0.1515204614.git.tim.c.chen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cda39b693d0fec41bd65aa17e7d7ea6bcbf48cc0.1515204614.git.tim.c.chen@linux.intel.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org

On Fri, Jan 05, 2018 at 06:12:23PM -0800, Tim Chen wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
> 
> We are impervious to the indirect branch prediction attack with retpoline
> but firmware won't be, so we still need to set IBRS to protect
> firmware code execution when calling into firmware at runtime.
> 
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
> ---
>  arch/x86/include/asm/apm.h       |  6 ++++++
>  arch/x86/include/asm/efi.h       | 17 +++++++++++++--
>  arch/x86/include/asm/spec_ctrl.h |  3 +++
>  arch/x86/kernel/cpu/spec_ctrl.c  | 45 ++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 69 insertions(+), 2 deletions(-)

The files that Alan pointed out as being missed in the last version of
this patch don't seem to be updated here either :(

thanks,

greg k-h