Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbeAFJBw (ORCPT + 1 other); Sat, 6 Jan 2018 04:01:52 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43364 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752575AbeAFJBv (ORCPT ); Sat, 6 Jan 2018 04:01:51 -0500 Date: Sat, 6 Jan 2018 10:01:54 +0100 From: Greg KH To: Dan Williams Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Hideaki YOSHIFUJI , netdev@vger.kernel.org, peterz@infradead.org, Alexey Kuznetsov , tglx@linutronix.de, torvalds@linux-foundation.org, "David S. Miller" , Elena Reshetova , alan@linux.intel.com Subject: Re: [PATCH 14/18] ipv4: prevent bounds-check bypass via speculative execution Message-ID: <20180106090154.GE4380@kroah.com> References: <151520099201.32271.4677179499894422956.stgit@dwillia2-desk3.amr.corp.intel.com> <151520107001.32271.12149241186695668220.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <151520107001.32271.12149241186695668220.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Jan 05, 2018 at 05:11:10PM -0800, Dan Williams wrote: > Static analysis reports that 'offset' may be a user controlled value Can I see the rule that determined that? It does not feel like that is correct, given the 3+ levels deep that this function gets this value from... Same for the ipv6 patch, it's the same code logic. thanks, greg k-h