Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753154AbeAFMCO (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Sat, 6 Jan 2018 07:02:14 -0500
Received: from emh06.mail.saunalahti.fi ([62.142.5.116]:37726 "EHLO
        emh06.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751608AbeAFMCN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 6 Jan 2018 07:02:13 -0500
Date: Sat, 6 Jan 2018 14:02:11 +0200
From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Linus Torvalds <torvalds@linux-foundation.org>,
        Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BISECTED] v4.15-rc: Boot regression on x86_64/AMD
Message-ID: <20180106120211.gibjmzrbi5hcpexj@darkstar.musicnaut.iki.fi>
References: <20180105220412.fzpwqe4zljdawr36@darkstar.musicnaut.iki.fi>
 <CA+55aFxCSWCG7ZvHW3AkLPzMPMAuG1BhL8fNgC0-JPYU4LZVow@mail.gmail.com>
 <20180106021038.ydvkbctsq24m6kgk@darkstar.musicnaut.iki.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180106021038.ydvkbctsq24m6kgk@darkstar.musicnaut.iki.fi>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Hi,

On Sat, Jan 06, 2018 at 04:10:38AM +0200, Aaro Koskinen wrote:
> On Fri, Jan 05, 2018 at 04:00:25PM -0800, Linus Torvalds wrote:
> > On Fri, Jan 5, 2018 at 2:04 PM, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> > > After v4.14, I've been unable to boot my AMD compilation box with the
> > > v4.15-rc mainline Linux. It just ends up in a silent reboot loop.
> > >
> > > I bisected this to:
> > >
> > > commit fa564ad9636651fd11ec2c79c48dee844066f73a
> > > Author: Christian K?nig <christian.koenig@amd.com>
> > > Date:   Tue Oct 24 14:40:29 2017 -0500
> > >
> > >     x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 00-1f, 30-3f, 60-7f)
> > 
> > Hmm. That was reported to break boot earlier already.
> > 
> > The breakage was supposedly fixed by three patches from Christian:
> > 
> >   a19e2696135e: "x86/PCI: Only enable a 64bit BAR on single-socket AMD
> > Family 15h"
> > 
> >   470195f82e4e:  "x86/PCI: Fix infinite loop in search for 64bit BAR placement"
> > 
> > and a third one that was apparently never applied.
> > 
> > I'm not sure why that third patch was never applied, I'm including it here.
> > 
> > Does the system work for you if you apply that patch (instead of
> > reverting all of them)?
> 
> Yes, I think it now works.
> 
> When booting with kexec from v4.14:
> 89876f275e8d562912d9c238cd888b52065cf25c alone ==> boot fails.
> 89876f275e8d562912d9c238cd888b52065cf25c and the patch ==> boot OK.

I also re-tested with normal reboot/reset and BIOS boot (just to eliminate
any kexec side-effects), and the results are the same. The patch
"x86/PCI: limit the size of the 64bit BAR to 256GB" is fixing the boot
on my system.

A.