Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753080AbeAFM2C (ORCPT + 1 other); Sat, 6 Jan 2018 07:28:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:55124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752847AbeAFM2A (ORCPT ); Sat, 6 Jan 2018 07:28:00 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4656721727 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sat, 6 Jan 2018 12:27:55 +0000 From: Jonathan Cameron To: Aishwarya Pant Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] staging: iio: trigger: replace device_attr with device_attr_rw Message-ID: <20180106122755.62dae7f8@archlinux> In-Reply-To: <20180104105851.GA10434@mordor.localdomain> References: <20180104105851.GA10434@mordor.localdomain> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, 4 Jan 2018 16:28:51 +0530 Aishwarya Pant wrote: > This is a clean-up patch which replaces DEVICE_ATTR() macro with the > file permission specific DEVICE_ATTR_RW() macro for compaction and > readability. Done using coccinelle. > > Signed-off-by: Aishwarya Pant Whilst this driver is in theory going away (Lars, update on that?) I guess this is a minor improvement. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Also, note I changed the title to include the driver name as just putting to a directory is not much use for people trying to track down changes that matter to them. Jonathan > --- > drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c > index f389f5cca99d..71f11d7472c0 100644 > --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c > +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c > @@ -78,9 +78,9 @@ static int iio_bfin_tmr_set_state(struct iio_trigger *trig, bool state) > return 0; > } > > -static ssize_t iio_bfin_tmr_frequency_store(struct device *dev, > - struct device_attribute *attr, > - const char *buf, size_t count) > +static ssize_t frequency_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > { > struct iio_trigger *trig = to_iio_trigger(dev); > struct bfin_tmr_state *st = iio_trigger_get_drvdata(trig); > @@ -116,9 +116,9 @@ static ssize_t iio_bfin_tmr_frequency_store(struct device *dev, > return count; > } > > -static ssize_t iio_bfin_tmr_frequency_show(struct device *dev, > - struct device_attribute *attr, > - char *buf) > +static ssize_t frequency_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > { > struct iio_trigger *trig = to_iio_trigger(dev); > struct bfin_tmr_state *st = iio_trigger_get_drvdata(trig); > @@ -133,8 +133,7 @@ static ssize_t iio_bfin_tmr_frequency_show(struct device *dev, > return sprintf(buf, "%lu\n", val); > } > > -static DEVICE_ATTR(frequency, 0644, iio_bfin_tmr_frequency_show, > - iio_bfin_tmr_frequency_store); > +static DEVICE_ATTR_RW(frequency); > > static struct attribute *iio_bfin_tmr_trigger_attrs[] = { > &dev_attr_frequency.attr,