Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753289AbeAFMuk (ORCPT + 1 other); Sat, 6 Jan 2018 07:50:40 -0500 Received: from www381.your-server.de ([78.46.137.84]:54772 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752875AbeAFMuh (ORCPT ); Sat, 6 Jan 2018 07:50:37 -0500 Subject: Re: [PATCH 1/5] iio: buffer: use permission specific variants of DEVICE_ATTR To: Jonathan Cameron , Aishwarya Pant Cc: Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Julia Lawall , Joe Perches References: <20180106123521.3bacb64b@archlinux> From: Lars-Peter Clausen Message-ID: Date: Sat, 6 Jan 2018 13:50:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180106123521.3bacb64b@archlinux> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/06/2018 01:35 PM, Jonathan Cameron wrote: > On Thu, 4 Jan 2018 20:07:14 +0530 > Aishwarya Pant wrote: > >> This is a clean-up patch which replaces DEVICE_ATTR macro with the file >> permission specific DEVICE_ATTR_{RO/WO/RW} macros for compaction and >> readability. Done using coccinelle. > > Hmm. I'll be honest, I personally really dislike these macros. > They absolutely don't help with readability because they obscure > the connection between the attributes being created and their callbacks. > Short is not the same as more readable. FWIW fully agreed.