Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbeAFNTC (ORCPT + 1 other); Sat, 6 Jan 2018 08:19:02 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:31249 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753071AbeAFNTA (ORCPT ); Sat, 6 Jan 2018 08:19:00 -0500 X-IronPort-AV: E=Sophos;i="5.46,321,1511823600"; d="scan'208";a="307869906" Date: Sat, 6 Jan 2018 14:18:58 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Lars-Peter Clausen cc: Jonathan Cameron , Aishwarya Pant , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joe Perches Subject: Re: [PATCH 1/5] iio: buffer: use permission specific variants of DEVICE_ATTR In-Reply-To: Message-ID: References: <20180106123521.3bacb64b@archlinux> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sat, 6 Jan 2018, Lars-Peter Clausen wrote: > On 01/06/2018 01:35 PM, Jonathan Cameron wrote: > > On Thu, 4 Jan 2018 20:07:14 +0530 > > Aishwarya Pant wrote: > > > >> This is a clean-up patch which replaces DEVICE_ATTR macro with the file > >> permission specific DEVICE_ATTR_{RO/WO/RW} macros for compaction and > >> readability. Done using coccinelle. > > > > Hmm. I'll be honest, I personally really dislike these macros. > > They absolutely don't help with readability because they obscure > > the connection between the attributes being created and their callbacks. > > Short is not the same as more readable. > > FWIW fully agreed. Could there be variants that keep the function names as arguments, but keep the benefit of the simpler permission specification and ensuring that the right functions are provided for the given permissions? julia