Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753582AbeAFPtT (ORCPT + 1 other); Sat, 6 Jan 2018 10:49:19 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:57182 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753279AbeAFPtS (ORCPT ); Sat, 6 Jan 2018 10:49:18 -0500 Date: Sat, 6 Jan 2018 16:49:13 +0100 From: Andrew Lunn To: "lipeng (Y)" Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com Subject: Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics Message-ID: <20180106154913.GF12689@lunn.ch> References: <1515147504-86802-1-git-send-email-lipeng321@huawei.com> <1515147504-86802-7-git-send-email-lipeng321@huawei.com> <20180105145405.GC4038@lunn.ch> <7784fdd6-dbdc-0d5d-9ba1-e2f05594d1dc@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7784fdd6-dbdc-0d5d-9ba1-e2f05594d1dc@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > >Is it because the static void is on the previous line? > Yes, it is because the static void is on the previous line. > > I can add one patch to fix the previous line , and this patch will correct > automatically. > > do it need V2 patchset? or push a new patch after this patchset? Thanks for looking into this. This actually seems like a patch bug, but i think the consensus is to have the function type on the same line as the function name within Linux. No need for a v2. Just send followup patches. Andrew