Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbeAFUfs (ORCPT + 1 other); Sat, 6 Jan 2018 15:35:48 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:35174 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbeAFUfr (ORCPT ); Sat, 6 Jan 2018 15:35:47 -0500 X-Google-Smtp-Source: ACJfBosbX6z5HUHC5LucZbkSc8HeoggKTjcIWGUxWcgfaqhp1hvjsp3fwxsbpAAVhyjnPJZIpBX4QvVPOG3mOiQB+Po= MIME-Version: 1.0 In-Reply-To: <6c82c574-6810-1003-183c-44f79ae7554f@oracle.com> References: <1514083813-27047-1-git-send-email-nick.desaulniers@gmail.com> <52b547c5-509a-3a82-12cd-4d9d0a06b53f@oracle.com> <87e3dc74-5959-1ecf-6854-fda017c2c775@citrix.com> <6c82c574-6810-1003-183c-44f79ae7554f@oracle.com> From: Nick Desaulniers Date: Sat, 6 Jan 2018 12:35:45 -0800 Message-ID: Subject: Re: [Xen-devel] [PATCH] x86/xen/time: fix section mismatch for xen_init_time_ops() To: Boris Ostrovsky Cc: Andrew Cooper , Juergen Gross , x86@kernel.org, Linux Kernel Mailing List , Ingo Molnar , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 2, 2018 at 7:00 AM, Boris Ostrovsky wrote: > On 01/02/2018 09:32 AM, Andrew Cooper wrote: >> On 02/01/18 14:24, Juergen Gross wrote: >>> On 02/01/18 15:18, Boris Ostrovsky wrote: >>>> On 12/23/2017 09:50 PM, Nick Desaulniers wrote: >>>>> The header declares this function as __init but is defined in __ref >>>>> section. >>>>> >>>>> Signed-off-by: Nick Desaulniers >>>> AFAIK section attributes in header files are ignored by compiler anyway >>>> so I'd remove all of them. >>> Hmm, I'm not sure all future compilers will ignore the section >>> attributes. include/linux/init.h explictily mentions where to put >>> the attrubute in a prototype, so I'd rather keep it. >> Attributes in the declaration are for static analysis tools such as sparse. >> >> How else are you going to work out whether a section mismatch has occurred? > > Isn't this done based on definitions? > > Tons of __init routines don't have the attribute specified in header > files. In fact, even in this file (arch/x86/xen/xen-ops.h) there are > some that don't have it. > > -boris What are the next steps for getting this patch merged? This is the only function for which I get a compiler warning (with Clang). Do you require a patch instead that changes more function attributes, or can that be a follow up patch?