Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753122AbeAFVhs (ORCPT + 1 other); Sat, 6 Jan 2018 16:37:48 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36193 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbeAFVhq (ORCPT ); Sat, 6 Jan 2018 16:37:46 -0500 X-Google-Smtp-Source: ACJfBosLpRvHi+HzdVUnOtts371fZGiaddqbx176qOOsX7iBFPghfu3AGAz1cQpQDkwBtges7UWyaDYnGp7ZxAqDLXk= MIME-Version: 1.0 In-Reply-To: <20180106131434.550e8e42@archlinux> References: <1514556006-23293-1-git-send-email-mastichi@gmail.com> <20171229175449.760e734d@archlinux> <20180101095342.4d4d5325@archlinux> <20180106131434.550e8e42@archlinux> From: Dmitry Mastykin Date: Sun, 7 Jan 2018 00:37:44 +0300 Message-ID: Subject: Re: [PATCH v2] iio: adc: max9611: fix module auto-loading To: Jonathan Cameron Cc: Andy Shevchenko , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jacopo Mondi , Dan Carpenter , Rob Herring , linux-iio@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sat, Jan 6, 2018 at 4:14 PM, Jonathan Cameron wrote: > Are you using devicetree or some other method to instantiate the device? > i.e. How does the kernel know it exists? > Yes, I'm using device-tree (in a way like in bindings txt). I have also max1137 connected, which is loaded and probed well. Thank you! Dmitry >> >> >> > Signed-off-by: Dmitry Mastykin >> >> >> > --- >> >> >> > drivers/iio/adc/max9611.c | 5 ++--- >> >> >> > 1 file changed, 2 insertions(+), 3 deletions(-) >> >> >> > >> >> >> > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c >> >> >> > index b1dd17c..ce0115a 100644 >> >> >> > --- a/drivers/iio/adc/max9611.c >> >> >> > +++ b/drivers/iio/adc/max9611.c >> >> >> > @@ -523,8 +523,7 @@ static const struct of_device_id max9611_of_table[] = { >> >> >> > }; >> >> >> > >> >> >> > MODULE_DEVICE_TABLE(of, max9611_of_table); >> >> >> > -static int max9611_probe(struct i2c_client *client, >> >> >> > - const struct i2c_device_id *id) >> >> >> > +static int max9611_probe(struct i2c_client *client) >> >> >> > { >> >> >> > const char * const shunt_res_prop = "shunt-resistor-micro-ohms"; >> >> >> > const struct device_node *of_node = client->dev.of_node; >> >> >> > @@ -576,7 +575,7 @@ static struct i2c_driver max9611_driver = { >> >> >> > .owner = THIS_MODULE, >> >> >> > .of_match_table = max9611_of_table, >> >> >> > }, >> >> >> > - .probe = max9611_probe, >> >> >> > + .probe_new = max9611_probe, >> >> >> > }; >> >> >> > module_i2c_driver(max9611_driver); >> >> >> > >> >> >> > -- >> >> >> > 2.7.4 >> >> >> > >> > >