Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753390AbeAFWZv (ORCPT + 1 other); Sat, 6 Jan 2018 17:25:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60612 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752470AbeAFWZt (ORCPT ); Sat, 6 Jan 2018 17:25:49 -0500 Date: Sat, 6 Jan 2018 23:25:39 +0100 From: Stefano Brivio To: SF Markus Elfring Cc: netdev@vger.kernel.org, Bhumika Goyal , "David S. Miller" , David Windsor , Elena Reshetova , Hans Liljestrand , Johannes Berg , Kees Cook , Roopa Prabhu , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] atm/clip: Use seq_puts() in svc_addr() Message-ID: <20180106232539.5d6bb620@elisabeth> In-Reply-To: <97636808-1d9f-d196-ebce-fbd2505c50e2@users.sourceforge.net> References: <97636808-1d9f-d196-ebce-fbd2505c50e2@users.sourceforge.net> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sat, 06 Jan 2018 22:25:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sat, 6 Jan 2018 22:44:08 +0100 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 6 Jan 2018 22:34:12 +0100 > > Two strings should be quickly put into a sequence by two function calls. > Thus use the function "seq_puts" instead of "seq_printf". > > This issue was detected by using the Coccinelle software. Can you please explain what the issue really is and what you're trying to do here? One shouldn't need to dig into Coccinelle patterns to find out what you mean, and "strings should be quickly put into a sequence" isn't terribly helpful. -- Stefano