Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752582AbeAGIuf (ORCPT + 1 other); Sun, 7 Jan 2018 03:50:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:34265 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbeAGIud (ORCPT ); Sun, 7 Jan 2018 03:50:33 -0500 Date: Sun, 7 Jan 2018 09:50:31 +0100 From: Michal Hocko To: Guenter Roeck , Andrew Morton Cc: James Hogan , linux-metag@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map' Message-ID: <20180107085031.GA24862@dhcp22.suse.cz> References: <20180107010733.GA317@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180107010733.GA317@roeck-us.net> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sat 06-01-18 17:07:33, Guenter Roeck wrote: > The following build error is seen when building metag:meta2_defconfig > or metag:tz1090_defconfig. > > arch/metag/kernel/process.c: In function '__metag_elf_map': > arch/metag/kernel/process.c:421: error: 'tsk' undeclared Sorry about that and thanks for your report. The following should fix the issue. Andrew, could you fold it to the original patch please? --- >From 64da2e0c134ecf3936a4c36b949bcf2cdc98977e Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Sun, 7 Jan 2018 09:47:41 +0100 Subject: [PATCH] fs-elf-drop-map_fixed-usage-from-elf_map-fix-fix The following build error is seen when building metag:meta2_defconfig or metag:tz1090_defconfig. arch/metag/kernel/process.c: In function '__metag_elf_map': arch/metag/kernel/process.c:421: error: 'tsk' undeclared Reported-by: Guenter Roeck Signed-off-by: Michal Hocko --- arch/metag/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c index 9e007195038d..0cca2c95a091 100644 --- a/arch/metag/kernel/process.c +++ b/arch/metag/kernel/process.c @@ -419,7 +419,7 @@ unsigned long __metag_elf_map(struct file *filep, unsigned long addr, if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr)) pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n", - task_pid_nr(current), tsk->comm, (void *)addr); + task_pid_nr(current), current->comm, (void *)addr); if (!BAD_ADDR(map_addr) && tcm_tag != TCM_INVALID_TAG) { struct tcm_allocation *tcm; -- 2.15.1 -- Michal Hocko SUSE Labs