Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752696AbeAGJw7 (ORCPT + 1 other); Sun, 7 Jan 2018 04:52:59 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:52277 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069AbeAGJw5 (ORCPT ); Sun, 7 Jan 2018 04:52:57 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Sun, 07 Jan 2018 10:52:39 +0100 From: Stefan Agner To: Rob Herring Cc: shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bai Ping Subject: Re: [PATCH 3/7] ARM: dts: imx6ull: add additional pinfunc defines for i.MX 6ULL In-Reply-To: <20180105164930.qomk75eo7vzyglvn@rob-hp-laptop> References: <20180102164223.15230-1-stefan@agner.ch> <20180102164223.15230-3-stefan@agner.ch> <20180105164930.qomk75eo7vzyglvn@rob-hp-laptop> Message-ID: User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 2018-01-05 17:49, Rob Herring wrote: > On Tue, Jan 02, 2018 at 05:42:19PM +0100, Stefan Agner wrote: >> From: Bai Ping >> >> On i.MX 6ULL, the pin MUX and CTRL register of BOOT_MODEx and TAMPERx >> pins are available through IOMUXC_SNVS. Add additional pinfunc defines. >> >> Signed-off-by: Bai Ping >> Signed-off-by: Stefan Agner >> --- >> arch/arm/boot/dts/imx6ull-pinfunc-snvs.h | 29 +++++++++++++++++++++++++++++ >> arch/arm/boot/dts/imx6ull.dtsi | 1 + >> 2 files changed, 30 insertions(+) >> create mode 100644 arch/arm/boot/dts/imx6ull-pinfunc-snvs.h >> >> diff --git a/arch/arm/boot/dts/imx6ull-pinfunc-snvs.h b/arch/arm/boot/dts/imx6ull-pinfunc-snvs.h >> new file mode 100644 >> index 000000000000..da3f412e4269 >> --- /dev/null >> +++ b/arch/arm/boot/dts/imx6ull-pinfunc-snvs.h >> @@ -0,0 +1,29 @@ >> +/* >> + * Copyright (C) 2016 Freescale Semiconductor, Inc. > > It's 2018 now. > I don't think you are supposed to chance copyright year unless you change it significantly. At least that article suggests so: https://www.copyrightlaws.com/copyright-notice-year/ I took that patch from the downstream NXP kernel, so I guess 2016 was the year of first publication... >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. > > Use SPDX. With that, Agreed. > > Reviewed-by: Rob Herring -- Stefan