Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754159AbeAGQI1 (ORCPT + 1 other); Sun, 7 Jan 2018 11:08:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:40826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754017AbeAGQI0 (ORCPT ); Sun, 7 Jan 2018 11:08:26 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5950A2075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 7 Jan 2018 16:08:20 +0000 From: Jonathan Cameron To: Dmitry Mastykin Cc: Andy Shevchenko , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jacopo Mondi , Dan Carpenter , Rob Herring , linux-iio@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v2] iio: adc: max9611: fix module auto-loading Message-ID: <20180107160820.05660804@archlinux> In-Reply-To: References: <1514556006-23293-1-git-send-email-mastichi@gmail.com> <20171229175449.760e734d@archlinux> <20180101095342.4d4d5325@archlinux> <20180106131434.550e8e42@archlinux> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, 7 Jan 2018 00:37:44 +0300 Dmitry Mastykin wrote: > On Sat, Jan 6, 2018 at 4:14 PM, Jonathan Cameron wrote: > > Are you using devicetree or some other method to instantiate the device? > > i.e. How does the kernel know it exists? > > > Yes, I'm using device-tree (in a way like in bindings txt). I have > also max1137 connected, which is loaded and probed well. > Thank you! If you wouldn't mind, could you post the snippet of the tree for this device. I'm still not sure why it isn't probing, but it could be that the manufacturer isn't specified, but just the part number? Jonathan > Dmitry > > >> >> >> > Signed-off-by: Dmitry Mastykin > >> >> >> > --- > >> >> >> > drivers/iio/adc/max9611.c | 5 ++--- > >> >> >> > 1 file changed, 2 insertions(+), 3 deletions(-) > >> >> >> > > >> >> >> > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c > >> >> >> > index b1dd17c..ce0115a 100644 > >> >> >> > --- a/drivers/iio/adc/max9611.c > >> >> >> > +++ b/drivers/iio/adc/max9611.c > >> >> >> > @@ -523,8 +523,7 @@ static const struct of_device_id max9611_of_table[] = { > >> >> >> > }; > >> >> >> > > >> >> >> > MODULE_DEVICE_TABLE(of, max9611_of_table); > >> >> >> > -static int max9611_probe(struct i2c_client *client, > >> >> >> > - const struct i2c_device_id *id) > >> >> >> > +static int max9611_probe(struct i2c_client *client) > >> >> >> > { > >> >> >> > const char * const shunt_res_prop = "shunt-resistor-micro-ohms"; > >> >> >> > const struct device_node *of_node = client->dev.of_node; > >> >> >> > @@ -576,7 +575,7 @@ static struct i2c_driver max9611_driver = { > >> >> >> > .owner = THIS_MODULE, > >> >> >> > .of_match_table = max9611_of_table, > >> >> >> > }, > >> >> >> > - .probe = max9611_probe, > >> >> >> > + .probe_new = max9611_probe, > >> >> >> > }; > >> >> >> > module_i2c_driver(max9611_driver); > >> >> >> > > >> >> >> > -- > >> >> >> > 2.7.4 > >> >> >> > > >> > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html