Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754445AbeAGSeO (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Sun, 7 Jan 2018 13:34:14 -0500
Received: from mga01.intel.com ([192.55.52.88]:51832 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754191AbeAGSeM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 7 Jan 2018 13:34:12 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,327,1511856000"; 
   d="scan'208";a="25164159"
Subject: Re: [PATCH v2] x86/mm/pti: remove dead logic during user pagetable
 population
To: Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>
References: <20180107103317.22613-1-albcamus@gmail.com>
 <20180107113655.zaovtpdfyjboccae@pd.tnic>
 <alpine.DEB.2.20.1801071303540.2094@nanos>
Cc: Jike Song <albcamus@gmail.com>, linux-kernel@vger.kernel.org,
        David Woodhouse <dwmw@amazon.co.uk>,
        Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
        Jiri Koshina <jikos@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Andi Lutomirski <luto@amacapital.net>,
        Andi Kleen <ak@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Paul Turner <pjt@google.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Greg KH <gregkh@linux-foundation.org>,
        Kees Cook <keescook@google.com>, stable@vger.kernel.org
From: Dave Hansen <dave.hansen@intel.com>
Message-ID: <58af26cd-dd39-a544-6449-e59d485bc551@intel.com>
Date: Sun, 7 Jan 2018 10:34:11 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1801071303540.2094@nanos>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 01/07/2018 04:05 AM, Thomas Gleixner wrote:
>> static DEFINE_SPINLOCK(shadow_table_allocation_lock);
>>
>> Now I have my suspicions why that's not needed anymore upstream but I'd
>> let tglx explain better.
> We got rid of all that runtime mapping stuff and the functions are only
> called from pti_init(). So the locking and therefor the tests above are not
> needed anymore. While at it we should mark all those function __init.

Yes, the double-test was part of an optimization where we attempted to
avoid using a global spinlock in the fork() path.  We would check for
unallocated mid-level page tables without the lock.  The lock was only
taken it when we needed to *make* an entry to avoid collisions.

Now that it is all single-threaded, there is no chance of a collision,
no need for a lock, and no need for the re-check.

^^ Just in case someone wants to include a bit more first-hand
information about wtf that code was doing there.