Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754506AbeAGSpO (ORCPT + 1 other); Sun, 7 Jan 2018 13:45:14 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:38960 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754459AbeAGSpM (ORCPT ); Sun, 7 Jan 2018 13:45:12 -0500 Date: Sun, 7 Jan 2018 19:44:55 +0100 From: Alexandre Belloni To: Daniel Lezcano Cc: Thomas Gleixner , Nicolas Ferre , Boris Brezillon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] clocksource/drivers: atmel-pit: allow unselecting ATMEL_PIT Message-ID: <20180107184455.GG5545@piout.net> References: <20180105143006.5369-1-alexandre.belloni@free-electrons.com> <20180105143006.5369-4-alexandre.belloni@free-electrons.com> <64398ab7-fbc6-0313-ccc6-51ff02d087e6@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64398ab7-fbc6-0313-ccc6-51ff02d087e6@linaro.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 07/01/2018 at 19:07:13 +0100, Daniel Lezcano wrote: > On 05/01/2018 15:30, Alexandre Belloni wrote: > > With the new TCB clocksource driver, atmel platforms are now able to boot > > without the PIT driver. Allow unselecting it. > > > > Signed-off-by: Alexandre Belloni > > --- > > drivers/clocksource/Kconfig | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > index 5609572e0236..55ccfa0ba63b 100644 > > --- a/drivers/clocksource/Kconfig > > +++ b/drivers/clocksource/Kconfig > > @@ -381,7 +381,14 @@ config ARMV7M_SYSTICK > > > > config ATMEL_PIT > > select TIMER_OF if OF > > - def_bool SOC_AT91SAM9 || SOC_SAMA5 > > + bool "Atmel Periodic Interval Timer (PIT)" > > + depends on SOC_AT91SAM9 || SOC_SAMA5 > > + default SOC_AT91SAM9 || SOC_SAMA5 > > + help > > + Select this to get a clocksource based on the Atmel Periodic Interval > > + Timer. It has a relatively low resolution and the TC Block clocksource > > + should be preferred. > > + It also provides a clock event device. > > Please conform to the format: > > config ATMEL_PIT > bool "Atmel Periodic Interval Timer (PIT)" if COMPILE_TEST > select ... > help > bla bla > > and select ATMEL_PIT from the platform's Kconfig. > Well, the goal is actually to allow people to unselect it so we don't want the platform to select it. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com