From: Song Liu <songliubraving@fb.com>
To: Yafang Shao <laoar.shao@gmail.com>
CC: David Miller <davem@davemloft.net>,
        "brendan.d.gregg@gmail.com" <brendan.d.gregg@gmail.com>,
        "marcelo.leitner@gmail.com" <marcelo.leitner@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net-next] net: tracepoint:  exposing sk_faimily in
 tracepoint inet_sock_set_state
Thread-Topic: [PATCH v2 net-next] net: tracepoint:  exposing sk_faimily in
 tracepoint inet_sock_set_state
Thread-Index: AQHTh4FTU3HnCuW71E25yE38X9waF6No5K6A
Date: Sun, 7 Jan 2018 20:55:26 +0000
Message-ID: <075DF50A-F4CD-4475-B393-1293BDF8E038@fb.com>
References: <1515306707-1759-1-git-send-email-laoar.shao@gmail.com>
In-Reply-To: <1515306707-1759-1-git-send-email-laoar.shao@gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <260E93C96C114846A579A69A1996238F@namprd15.prod.outlook.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a52b0db8-9461-40e4-c2af-08d55610fa69
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2018 20:55:26.2400
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1512
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-07_07:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>


> On Jan 6, 2018, at 10:31 PM, Yafang Shao <laoar.shao@gmail.com> wrote:
> 
> As of now, there're two sk_family are traced with sock:inet_sock_set_state,
> which are AF_INET and AF_INET6.
> So the sk_family are exposed as well.
> Then we can conveniently use it to do the filter.
> 
> Both sk_family and sk_protocol are showed in the printk message, so we need
> not expose them as tracepoint arguments.
> 
> Suggested-by: Brendan Gregg <brendan.d.gregg@gmail.com>
> Suggested-by: Song Liu <songliubraving@fb.com>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> ---
> include/trace/events/sock.h | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h
> index 3537c5f..3176a39 100644
> --- a/include/trace/events/sock.h
> +++ b/include/trace/events/sock.h
> @@ -11,7 +11,11 @@
> #include <linux/ipv6.h>
> #include <linux/tcp.h>
> 
> -/* The protocol traced by sock_set_state */
> +#define family_names			\
> +		EM(AF_INET)				\
> +		EMe(AF_INET6)
> +
> +/* The protocol traced by inet_sock_set_state */
> #define inet_protocol_names		\
> 		EM(IPPROTO_TCP)			\
> 		EM(IPPROTO_DCCP)		\
> @@ -37,6 +41,7 @@
> #define EM(a)       TRACE_DEFINE_ENUM(a);
> #define EMe(a)      TRACE_DEFINE_ENUM(a);
> 
> +family_names
> inet_protocol_names
> tcp_state_names
> 
> @@ -45,6 +50,9 @@
> #define EM(a)       { a, #a },
> #define EMe(a)      { a, #a }
> 
> +#define show_family_name(val)			\
> +	__print_symbolic(val, family_names)
> +
> #define show_inet_protocol_name(val)    \
> 	__print_symbolic(val, inet_protocol_names)
> 
> @@ -118,6 +126,7 @@
> 		__field(int, newstate)
> 		__field(__u16, sport)
> 		__field(__u16, dport)
> +		__field(__u16, family)
> 		__field(__u8, protocol)
> 		__array(__u8, saddr, 4)
> 		__array(__u8, daddr, 4)
> @@ -134,6 +143,7 @@
> 		__entry->oldstate = oldstate;
> 		__entry->newstate = newstate;
> 
> +		__entry->family = sk->sk_family;
> 		__entry->protocol = sk->sk_protocol;
> 		__entry->sport = ntohs(inet->inet_sport);
> 		__entry->dport = ntohs(inet->inet_dport);
> @@ -160,7 +170,8 @@
> 		}
> 	),
> 
> -	TP_printk("protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c oldstate=%s newstate=%s",
> +	TP_printk("family=%s protocol=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c oldstate=%s newstate=%s",
> +			show_family_name(__entry->family),
> 			show_inet_protocol_name(__entry->protocol),
> 			__entry->sport, __entry->dport,
> 			__entry->saddr, __entry->daddr,
> --
> 1.8.3.1
> 

Reviewed-by: Song Liu <songliubraving@fb.com>