Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755327AbeAHDC4 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Sun, 7 Jan 2018 22:02:56 -0500
Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:42012 "EHLO
        mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1754996AbeAHDCx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 7 Jan 2018 22:02:53 -0500
Subject: Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error
 injectable event is on function entry
To: Masami Hiramatsu <mhiramat@kernel.org>
References: <151427438796.32561.4235654585430455286.stgit@devbox>
 <151427441954.32561.8731119329264462024.stgit@devbox>
 <20171227015730.jjggymg4uqllteuy@ast-mbp>
 <20171227145628.53f68f391b2108d6df118ca7@kernel.org>
 <a4097830-ac90-4db0-b860-6f6a85e91cba@fb.com>
 <20171228113434.eb182c348fc69853fec934ee@kernel.org>
 <03e0ebb7-0b2a-4235-3408-c0d59a1ba4c2@fb.com>
 <20171227231644.168abc0f@vmware.local.home>
 <c66a969f-6854-ffa5-502d-bd194c5536bc@fb.com>
 <20171228172027.4a8f2f0cf0506499acd26738@kernel.org>
 <b6057235-a1f4-a461-a2d5-295e964249ea@fb.com>
 <20171229172022.8b184d85d3787bc7f8d1c45a@kernel.org>
CC: Steven Rostedt <rostedt@goodmis.org>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Josef Bacik <jbacik@fb.com>, <mingo@redhat.com>,
        <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <ast@kernel.org>,
        <kernel-team@fb.com>, <daniel@iogearbox.net>,
        <linux-btrfs@vger.kernel.org>, <darrick.wong@oracle.com>,
        Josef Bacik <josef@toxicpanda.com>,
        Akinobu Mita <akinobu.mita@gmail.com>
From: Alexei Starovoitov <ast@fb.com>
Message-ID: <64a6e39f-b925-de76-3e30-28ba98d180c8@fb.com>
Date: Sun, 7 Jan 2018 19:01:57 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20171229172022.8b184d85d3787bc7f8d1c45a@kernel.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [2620:10d:c090:180::ca86]
X-ClientProxiedBy: CY4PR13CA0031.namprd13.prod.outlook.com
 (2603:10b6:903:99::17) To BL2PR15MB0961.namprd15.prod.outlook.com
 (2603:10b6:201:15::23)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 354962d3-1522-4aac-818f-08d556443358
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:BL2PR15MB0961;
X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;3:JDxzMrb8DbbJPb/NI4Y/BVkKfWKbOWZ7B6nM9mZKq8YNGfUSR9FzOT64ywBXpAFm+jSHNyzlGD0ZHfuNlHXzfkeSNMW8UEOyteYt/i44Hlz17V959B9DgN7NJQI97ur0RUpS3Xm9Yr55FRnjWy34N1ch5P8vl3mvg+qLA2MLndJUYE3yeuOEroKHjMY2XO9N1cs5Eh6n4W7X8xDzzFouoWtrGKwq1bVi2d5J8oI5oX9w20kER/g4HEDji17W8f5I;25:GtNe8Xh0sqCrfu9o72ThsC4eQqmoiRFnC5YlTBLM3GWolrJq5+edasruCGr4A/n4teKHTrZSJJwHGRnIEoE/V+P5Bps33HniaC7t2LSJPBoF+exBdaL/5GVVGt20ArkH2YoGEr7eeDj6HrZwMZC0qcieKox+nNo7jxNnuER5Wk47qOliQykREzbU+AySGXoiudW3Uae0ayB6lZW/RUpsTP/waG5YTf8r8h86yMFJzOR4465ZlifztVqpZ9N14rdGDbADaBJiumnd7ysn07WAiTpacSYkMZ7scnbjLqwi6R+GMZEJUUDisZ9d/AVmB/aysVSY9iF2NiaGx0UgK8LbaQ==;31:tTQowX1QMBrpyli5NZ1ca1ekIUepv1Nu8VEN4Nx97OCMklMyzIabkelJ8ZIDhe5I0pYNaToBPXSsRWIMtFSqyIYRHVy3Wv/F3qFoR67VKrv7JfTn+ovAFlXoLKCpLH5lP8HRDHgSwWG8ihJZ8i6ac2psFxnRyxMN83riKPLNC8qHumsJQ8fzouNOLnf81cThXxWvscmIxyzli2ELkuj6tIHTqUu2oakaP9ctmABP1vw=
X-MS-TrafficTypeDiagnostic: BL2PR15MB0961:
X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;20:7IRyGGeQCrk50ueRbz1h3bfD3JvvuGVZqGn3sQOZoD0BI7k/4sQFxA63m2mxls4ODi7Rm7SV6Z1np5NyRqKWhS9gosCYk8CyRDl4tJHAJYAqW85GOT/TCKwcTIAU6E+JKJFSPHPy5jwGRp7Gars/3L3ZjD5SGzVAzm0XD81ywVunsq3YhoG6YVzVAsxtxiMNx9D2x4TbKHcVC1DkQsqx0JrR/CxS+bFU84NnYULpQnVie+FpviMRzlWwCsEYV93UwyERpM+j3pP2WzCOmltdje+OuUZHxZMtSiJbYIaTtqEr6Im4/9GpkTbYVsPuXFFHBLLjQSTQn+LvBePrU9LerOQyGz84WRpLp2prx3yacx3zml+GWntJxYquCVpwoFH5YwPJPQn9JATO0XRFblkh6bMekaHUTvuIxoippJB+DFZuAXkqZxcdyznHnSfSgOgA4eIoMLpbYbIyuGt46QgrwHAGyzPjAUG4ldXXJLzqINFEwZlQVQcg8fJ15+uDMkiG;4:ZVbvrsKjh+tKHcWUWtmeDnfg8bea1r1fTX6BpRbyAEUQ1d8/20lhToIEWuJlRBzDW8qZHs/lbRkJzB66rF9XkJ914IFLAkKm8WO9HqzOzR/K8ydF+dwoph+7k/z+ebwNzTooSooUZG1Yt4iHtMpRicLNa/BbVoEJXMVDrjMhUXFrJU3Jy2ivqhEjOIFBFJ4Skjra1kbgCrYxhW85LzmjGNO332sb4tHNxcVbiTy2VPtaWU7RxHKcWKwujl2/zXOy4TehwxMFBrixWm9fx0dkXw==
X-Microsoft-Antispam-PRVS: <BL2PR15MB09618ED87BF72041BA9BCD14D7130@BL2PR15MB0961.namprd15.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231023)(11241501184)(944501075)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:BL2PR15MB0961;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BL2PR15MB0961;
X-Forefront-PRVS: 054642504A
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(39860400002)(346002)(376002)(396003)(366004)(39380400002)(24454002)(199004)(189003)(50466002)(106356001)(6666003)(25786009)(6916009)(2950100002)(93886005)(4326008)(316002)(105586002)(64126003)(31686004)(478600001)(58126008)(83506002)(54906003)(65826007)(6246003)(68736007)(52116002)(97736004)(5660300001)(31696002)(39060400002)(2906002)(53936002)(76176011)(65956001)(36756003)(65806001)(8936002)(230700001)(1706002)(6116002)(8676002)(81156014)(81166006)(386003)(23746002)(52396003)(305945005)(7736002)(7416002)(67846002)(6486002)(86362001)(53546011)(229853002)(47776003)(42262002)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR15MB0961;H:[IPv6:2620:10d:c081:1130::1187];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en;
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BL2PR15MB0961;23:4X0/7N01LXapoPPymcQ/fv3Ipt8ZgrhCNUiQ/?=
 =?Windows-1252?Q?ghrLvw//+oro7EJy5jKVZh3y0rMIbRJakkTTmeRBm3YTn3wTZu9Cey39?=
 =?Windows-1252?Q?l0+8ikWXiBT/3fA4B0XSrlFMKthlnqGKU1RK6ZY7wzqszYqWpV92Tl3P?=
 =?Windows-1252?Q?jYBh2bdyBs5eIEivyJgsOWoDFP0/vHRofR+iIYmjfCKgmuHtAM+tJ4Ir?=
 =?Windows-1252?Q?ld88fs0zs12R5cuVHtSlGQurUy+lXj6KsAXtG831wg46G8aCy2lWFCAd?=
 =?Windows-1252?Q?gXCulI690TTEECbqfHDzjZGWKh1wQPiWzvcB5lgSWD1dAbvLJEIko90m?=
 =?Windows-1252?Q?SFzoSSrPagTxf/L+ZOYrE1XFBrcpjzvmjjwzDnuQkSKqJyTjdPenbO/u?=
 =?Windows-1252?Q?A2lgTXJ9r6bzBigu+7fvARxFROh94iUF845YWl6NkbumB/bIh2Cjl5ke?=
 =?Windows-1252?Q?FlvM+JslpI2Jiht2d+ZZ/HXGBxGcV3a3zLbcLmRlQ/Lef+oKvdt2Ht3o?=
 =?Windows-1252?Q?up8iFyC1l2MIpPptlMw7KVgom76xRRSnm85+8fgQ9M7T3ej8/hDkRVdI?=
 =?Windows-1252?Q?NMoi+Pc+9tBGfBFi3/0PkXUC/1+7vNBcOMtRKUKDqwjFKrmyu0fV6AwD?=
 =?Windows-1252?Q?ormuvnPspvmUrifRpLDzAjaVFfpW0vK+YxiVw75NpecmFBNTq8+g6gp5?=
 =?Windows-1252?Q?KaYNH9pXT/q7M4nQUMc9IKtof+M4O8opvmqOZIHkWhlCKsfJpeodkVcD?=
 =?Windows-1252?Q?oAshD0ktwYrNl1NpKgn6f0T2NgxtnO3t8hhb+++Ubi9NloypXLAWpFz2?=
 =?Windows-1252?Q?f79GW/W+xGENlxpRb8TeboQHoM89ZTnkfxBQ37y5alVrH07qaXbqGaCW?=
 =?Windows-1252?Q?MVucQhRqJbiIkE5gUCK0/cZFeu/M23wlfLMt9q6mziiQMOR+c/g0wedP?=
 =?Windows-1252?Q?oELBT7cBXdbyda/lhI9uL7eoIFpRZjgsxLZRMBDCAck7/qf11KBLuv4q?=
 =?Windows-1252?Q?abcNUmme6FDqXcqbDNCTK/s+2pnGSdxH4Xwrt3nQh5otUIA6s7i/dRQ/?=
 =?Windows-1252?Q?qfl92mxYUmNzGTK9fg6fE++8gLPlt6m6sYHEWCAQd1HarYIlOa0hFIFa?=
 =?Windows-1252?Q?D+NhWHlrWu3mkn5nnfU4lPHd458mwrYN9rgwKWUIH+VwrBrl3Yrm5Yvm?=
 =?Windows-1252?Q?TVEZGqvA9abAC+oViLzAqUzp1ExGgt7MttjHjWkONm2AMkVhutZyhmcj?=
 =?Windows-1252?Q?g4EFG5mT6T+18HNogWvYUWyrPeApSp+Gz/nviKUZagBgu9wtq1ijN+Ke?=
 =?Windows-1252?Q?TUy8DOVfMMOBS2JIV8vfSCFgJgNZif3cXXD+URDS7+cC/awfhkni0ix5?=
 =?Windows-1252?Q?7IK6ZvCj18Q9nJ0sFz+t+lwnoRVDxKriVEiqEgxwTXe+TqTQfd07KHyd?=
 =?Windows-1252?Q?7ALOy7mUaakL92if+dp8iXovVeYKdyz4KEG8BJf3rViyc46HTZ9yUV5m?=
 =?Windows-1252?Q?bfgHpc=3D?=
X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;6:U1w0Iatt8t4EX85oCT7AqOlryFlwu7vHfI4TjPnKcg708n7kBfJ1XLLE00tsAv59bot/UMg00yUGSoLFjsBciIqIZb4LFd1ehMZ8rJL8uHjISdWfAmN7CClpHPhGnpT8Ty+rzZyj2ez0ngTOLj0xaeIJFlByScI+QiMjDbtvG5M520kmEgt0TD4e1khESjJPsY+tB7CnkH1aDwAZAp891g1wP1PzG4dU08xMaCihHULVpfjdukXNCiIwsCY/Wi5PEWCTw+fj7YFNP4bZ7aorbX585R9p5crfzQhsxY68ST6etkjDc31+t4uYZWxj3CaHxC916uitsdsijppQ0dwOyL6zg1MLc0l/vMMSi7D2WlU=;5:NwcWV/TjyP4IPx6AABT/sZxChMgMs5EYMuAXhgrzS7eiksmTBSecO31hQ0FKEl8xU3EUPVqCeOhaPG/6lOupqkmf/VXiOYNoJGG2kyAryGQDF++XcCGRNwe/JXnfxMD+3hmTYm0mGYKdR9+V4mYfuFBTjABztgybjOFtxFdLvwM=;24:l8ocmfn539J7OSyFAHwuo6Gh0urqVEVN6TZr8lMpzOtDsjsuKBSQnrlLh5ogzkj6XvNW63X7FzaiSf5ygP9iVIYMw1h3sRnPVZh5k/2Amdc=;7:uxchJU1BADGCSRk/ZN6vjZ0QB82sqa2Mv7tCoIkIFLGg2EXgOUb3jRGJld4uxz/Nl0HFJTfzwGs53BMHhtXmrfbqlB1sxcDEHOmB9KKJ2IZgBOMPolXdYnJ4kS6a3bkah7BxkRHLQsmOoVA22lq1yWc3/TZmECe3NX+W8CoD1L+cbMnQf+gkAL2Kdit5drSLl96iPThKYZfRrQcewKsxgfpqs6ln929mDO85z/oFhbEQ4sgcItuR8XBysyuocobc
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;20:t89v476DOOHcNYu7ZfkID9wK5Y4Eq/sXWG7v6vmBPmhkhcRupJbPpXxTgzHPCHiyXT3By0tNY1GEFBnA+IGe7eu2DIpHMur+DIx5alSaMjt0ojpVuMGt6jmfVVBpcvvBQLUGMy1Z7ge/kXW6F/FsJuRfdvUTFMFgZaHRbpnwi70=
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2018 03:02:03.7933 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 354962d3-1522-4aac-818f-08d556443358
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR15MB0961
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-08_02:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 12/29/17 12:20 AM, Masami Hiramatsu wrote:
>> Please run Josef's test in the !ftrace setup.
> Yes, I'll add the result of the test case.

if Josef's test is passing in !ftrace config,
please resend your patches.
I think 2 and 3 were nice simplifications.
and patch 1 is good too if it's passes the test.
Would be great to get them in for this merge window.

Thanks!