DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B85A260346
Subject: Re: [PATCH v4 14/16] phy: Add USB speed related PHY modes
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Felipe Balbi <balbi@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-usb@vger.kernel.org,
        "open list:GENERIC PHY FRAMEWORK" <linux-kernel@vger.kernel.org>
References: <1514978930-31341-1-git-send-email-mgautam@codeaurora.org>
 <1514978930-31341-15-git-send-email-mgautam@codeaurora.org>
 <15b9b9e7-ae4f-2b40-4bf5-265534d4605e@ti.com>
From: Manu Gautam <mgautam@codeaurora.org>
Message-ID: <8cff4f9d-4ff3-f7a5-cbb2-677c34c1a637@codeaurora.org>
Date: Mon, 8 Jan 2018 10:16:01 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <15b9b9e7-ae4f-2b40-4bf5-265534d4605e@ti.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org

Hi,

On 1/5/2018 4:31 PM, Kishon Vijay Abraham I wrote:
>> +enum phy_mode phy_get_mode(struct phy *phy)
>> +{
>> +	enum phy_mode ret;
>> +
>> +	if (!phy || !phy->ops->get_mode)
>> +		return PHY_MODE_INVALID;
>> +
>> +	mutex_lock(&phy->mutex);
>> +	ret = phy->ops->get_mode(phy);
> Since get_mode only has to return the phy mode, there is no need for an ops
> here. Just add phy_mode in phy_attrs in set_mode and return it here.

Sure, will re-send patch set with this change.


-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project