Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753584AbeAHFTe (ORCPT + 1 other); Mon, 8 Jan 2018 00:19:34 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55098 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751071AbeAHFTd (ORCPT ); Mon, 8 Jan 2018 00:19:33 -0500 Date: Sun, 7 Jan 2018 21:19:41 -0800 From: Srikar Dronamraju To: Ravi Bangoria Cc: rostedt@goodmis.org, mingo@redhat.com, oleg@redhat.com, linux-kernel@vger.kernel.org, namhyung@kernel.org Subject: Re: [PATCH] trace_uprobe: Display correct offset in uprobe_events Reply-To: Srikar Dronamraju References: <20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18010805-0012-0000-0000-000005A0D943 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18010805-0013-0000-0000-0000191C2F83 Message-Id: <20180108051941.GA14372@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-08_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801080076 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: * Ravi Bangoria [2018-01-06 11:12:46]: > Recently, how the pointers being printed with %p has been changed > by commit ad67b74d2469 ("printk: hash addresses printed with %p"). > This is causing a regression while showing offset in the > uprobe_events file. Instead of %p, use %px to display offset. > > Signed-off-by: Ravi Bangoria > --- > kernel/trace/trace_uprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 40592e7b3568..268029ae1be6 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_file *m, void *v) > > /* Don't print "0x (null)" when offset is 0 */ > if (tu->offset) { > - seq_printf(m, "0x%p", (void *)tu->offset); > + seq_printf(m, "0x%px", (void *)tu->offset); > } else { > switch (sizeof(void *)) { > case 4: Looks good to me. Did you consider %pK instead of %px? Acked-by: Srikar Dronamraju