Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755487AbeAHFgD (ORCPT + 1 other); Mon, 8 Jan 2018 00:36:03 -0500 Received: from anchovy2.45ru.net.au ([203.30.46.146]:51837 "EHLO anchovy.45ru.net.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754579AbeAHFgC (ORCPT ); Mon, 8 Jan 2018 00:36:02 -0500 X-Greylist: delayed 400 seconds by postgrey-1.27 at vger.kernel.org; Mon, 08 Jan 2018 00:36:01 EST Subject: Re: [PATCH] pinctrl: mcp23s08: fix irq setup order To: Linus Walleij , Dmitry Mastykin , Sebastian Reichel Cc: linux-gpio@vger.kernel.org, "linux-kernel@vger.kernel.org" References: <1514474364-32169-1-git-send-email-mastichi@gmail.com> From: Phil Reid Message-ID: Date: Mon, 8 Jan 2018 13:29:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 2/01/2018 17:10, Linus Walleij wrote: > On Thu, Dec 28, 2017 at 4:19 PM, Dmitry Mastykin wrote: > >> When using mcp23s08 module with gpio-keys, often (50% of boots) >> it fails to get irq numbers with message: >> "gpio-keys keys: Unable to get irq number for GPIO 0, error -6". >> Seems that irqs must be setup before devm_gpiochip_add_data(). >> >> Signed-off-by: Dmitry Mastykin > > Patch applied, albeit for devel. > > Should it be tagged for stable or go into fixes? > I'm no expert on this one, but looking at other drivers they're using a mixture of ordering for irq setup and devm_gpiochip_add_data() calls. But should probably go into stable if it is the fix. -- Regards Phil Reid