Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755587AbeAHG3z (ORCPT + 1 other); Mon, 8 Jan 2018 01:29:55 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34720 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755458AbeAHG3y (ORCPT ); Mon, 8 Jan 2018 01:29:54 -0500 Subject: Re: [PATCH] trace_uprobe: Display correct offset in uprobe_events To: Srikar Dronamraju Cc: rostedt@goodmis.org, mingo@redhat.com, oleg@redhat.com, linux-kernel@vger.kernel.org, namhyung@kernel.org, me@tobin.cc, Ravi Bangoria References: <20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com> <20180108051941.GA14372@linux.vnet.ibm.com> From: Ravi Bangoria Date: Mon, 8 Jan 2018 12:01:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180108051941.GA14372@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18010806-0020-0000-0000-000003E7D258 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18010806-0021-0000-0000-00004279ED04 Message-Id: <8b86c7ef-abb2-6f4a-f336-2271eab6f7cb@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-08_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801080095 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/08/2018 10:49 AM, Srikar Dronamraju wrote: > * Ravi Bangoria [2018-01-06 11:12:46]: > >> Recently, how the pointers being printed with %p has been changed >> by commit ad67b74d2469 ("printk: hash addresses printed with %p"). >> This is causing a regression while showing offset in the >> uprobe_events file. Instead of %p, use %px to display offset. >> >> Signed-off-by: Ravi Bangoria >> --- >> kernel/trace/trace_uprobe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c >> index 40592e7b3568..268029ae1be6 100644 >> --- a/kernel/trace/trace_uprobe.c >> +++ b/kernel/trace/trace_uprobe.c >> @@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_file *m, void *v) >> >> /* Don't print "0x (null)" when offset is 0 */ >> if (tu->offset) { >> - seq_printf(m, "0x%p", (void *)tu->offset); >> + seq_printf(m, "0x%px", (void *)tu->offset); >> } else { >> switch (sizeof(void *)) { >> case 4: > Looks good to me. Did you consider %pK instead of %px? Thanks Srikar, Checked %pK. But I see same issue with that: perf probe:   Opening /sys/kernel/debug/tracing//uprobe_events write=1   Writing event: p:probe_a/main /tmp/a.out:0x58c cat /sys/kernel/debug/tracing/uprobe_events:   p:probe_a/main /tmp/a.out:0x0000000014fd571e > Acked-by: Srikar Dronamraju