Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755632AbeAHGgH (ORCPT + 1 other); Mon, 8 Jan 2018 01:36:07 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45215 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755470AbeAHGgG (ORCPT ); Mon, 8 Jan 2018 01:36:06 -0500 X-ME-Sender: Date: Mon, 8 Jan 2018 17:35:59 +1100 From: "Tobin C. Harding" To: Ravi Bangoria Cc: Srikar Dronamraju , rostedt@goodmis.org, mingo@redhat.com, oleg@redhat.com, linux-kernel@vger.kernel.org, namhyung@kernel.org Subject: Re: [PATCH] trace_uprobe: Display correct offset in uprobe_events Message-ID: <20180108063559.GF2411@eros> References: <20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com> <20180108051941.GA14372@linux.vnet.ibm.com> <8b86c7ef-abb2-6f4a-f336-2271eab6f7cb@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8b86c7ef-abb2-6f4a-f336-2271eab6f7cb@linux.vnet.ibm.com> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 08, 2018 at 12:01:04PM +0530, Ravi Bangoria wrote: > > > On 01/08/2018 10:49 AM, Srikar Dronamraju wrote: > > * Ravi Bangoria [2018-01-06 11:12:46]: > > > >> Recently, how the pointers being printed with %p has been changed > >> by commit ad67b74d2469 ("printk: hash addresses printed with %p"). > >> This is causing a regression while showing offset in the > >> uprobe_events file. Instead of %p, use %px to display offset. > >> > >> Signed-off-by: Ravi Bangoria > >> --- > >> kernel/trace/trace_uprobe.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > >> index 40592e7b3568..268029ae1be6 100644 > >> --- a/kernel/trace/trace_uprobe.c > >> +++ b/kernel/trace/trace_uprobe.c > >> @@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_file *m, void *v) > >> > >> /* Don't print "0x (null)" when offset is 0 */ > >> if (tu->offset) { > >> - seq_printf(m, "0x%p", (void *)tu->offset); > >> + seq_printf(m, "0x%px", (void *)tu->offset); > >> } else { > >> switch (sizeof(void *)) { > >> case 4: > > Looks good to me. Did you consider %pK instead of %px? > > Thanks Srikar, > > Checked %pK. But I see same issue with that: > > perf probe: > ? Opening /sys/kernel/debug/tracing//uprobe_events write=1 > ? Writing event: p:probe_a/main /tmp/a.out:0x58c > > cat /sys/kernel/debug/tracing/uprobe_events: > ? p:probe_a/main /tmp/a.out:0x0000000014fd571e %pK behaves the same as %p (hashes address) when kpt_restrict==0 Hope this helps, Tobin.