Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755784AbeAHGyI (ORCPT + 1 other); Mon, 8 Jan 2018 01:54:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:37665 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755768AbeAHGyH (ORCPT ); Mon, 8 Jan 2018 01:54:07 -0500 Subject: Re: [PATCH v2] x86: xen: remove the use of VLAIS To: Nick Desaulniers Cc: ghackmann@google.com, mka@google.com, kees@google.com, srhines@google.com, Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <1515274788-24548-1-git-send-email-nick.desaulniers@gmail.com> From: Juergen Gross Message-ID: <64b3bc20-cef2-ce42-82a8-b7c3e0043a49@suse.com> Date: Mon, 8 Jan 2018 07:54:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1515274788-24548-1-git-send-email-nick.desaulniers@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 06/01/18 22:39, Nick Desaulniers wrote: > Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and > frowned upon by others. > > https://lkml.org/lkml/2013/9/23/500 > > Here, the VLAIS was used because the size of the bitmap returned from > xen_mc_entry() depended on possibly (based on kernel configuration) > runtime sized data. Rather than declaring args as a VLAIS then calling > sizeof on *args, we calculate the appropriate sizeof args manually. > Further, we can get rid of the #ifdef's and rely on num_possible_cpus() > (thanks to a helpful checkpatch warning from an earlier version of this > patch). > > Suggested-by: Juergen Gross > Signed-off-by: Nick Desaulniers Reviewed-by: Juergen Gross Juergen