Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755796AbeAHHXI (ORCPT + 1 other); Mon, 8 Jan 2018 02:23:08 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34285 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755598AbeAHHXG (ORCPT ); Mon, 8 Jan 2018 02:23:06 -0500 X-Google-Smtp-Source: ACJfBovRWRwbNv4air5jusGgIjLleGI1qwHd3O1FRTcJG2fdG4VF6sOsiwwVa1TG+PFz13fzwlD90g== Subject: Re: [PATCH v2 3/6] clocksource/drivers: atmel-pit: allow unselecting ATMEL_PIT To: Alexandre Belloni Cc: Thomas Gleixner , Nicolas Ferre , Boris Brezillon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20180105143006.5369-1-alexandre.belloni@free-electrons.com> <20180105143006.5369-4-alexandre.belloni@free-electrons.com> <64398ab7-fbc6-0313-ccc6-51ff02d087e6@linaro.org> <20180107184455.GG5545@piout.net> From: Daniel Lezcano Message-ID: Date: Mon, 8 Jan 2018 08:23:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180107184455.GG5545@piout.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 07/01/2018 19:44, Alexandre Belloni wrote: > On 07/01/2018 at 19:07:13 +0100, Daniel Lezcano wrote: >> On 05/01/2018 15:30, Alexandre Belloni wrote: >>> With the new TCB clocksource driver, atmel platforms are now able to boot >>> without the PIT driver. Allow unselecting it. >>> >>> Signed-off-by: Alexandre Belloni >>> --- >>> drivers/clocksource/Kconfig | 9 ++++++++- >>> 1 file changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >>> index 5609572e0236..55ccfa0ba63b 100644 >>> --- a/drivers/clocksource/Kconfig >>> +++ b/drivers/clocksource/Kconfig >>> @@ -381,7 +381,14 @@ config ARMV7M_SYSTICK >>> >>> config ATMEL_PIT >>> select TIMER_OF if OF >>> - def_bool SOC_AT91SAM9 || SOC_SAMA5 >>> + bool "Atmel Periodic Interval Timer (PIT)" >>> + depends on SOC_AT91SAM9 || SOC_SAMA5 >>> + default SOC_AT91SAM9 || SOC_SAMA5 >>> + help >>> + Select this to get a clocksource based on the Atmel Periodic Interval >>> + Timer. It has a relatively low resolution and the TC Block clocksource >>> + should be preferred. >>> + It also provides a clock event device. >> >> Please conform to the format: >> >> config ATMEL_PIT >> bool "Atmel Periodic Interval Timer (PIT)" if COMPILE_TEST >> select ... >> help >> bla bla >> >> and select ATMEL_PIT from the platform's Kconfig. >> > > Well, the goal is actually to allow people to unselect it so we don't > want the platform to select it. Why do you need people to unselect it? The goal of the Kconfig here is to be silent except in the case the COMPILE_TEST option is set for cross-compilation test coverage. We are migrating all these options to this format. Please make it silent. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog