Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756034AbeAHIr1 (ORCPT + 1 other); Mon, 8 Jan 2018 03:47:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:42204 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755984AbeAHIrZ (ORCPT ); Mon, 8 Jan 2018 03:47:25 -0500 Date: Mon, 8 Jan 2018 09:47:23 +0100 From: Michal Hocko To: Greg Kroah-Hartman Cc: Mike Galbraith , linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Kirill A. Shutemov" , Andrew Morton , Andy Lutomirski , Borislav Petkov , Cyrill Gorcunov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , linux-mm@kvack.org, Ingo Molnar Subject: Re: [PATCH 4.14 023/159] mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y Message-ID: <20180108084723.GC5717@dhcp22.suse.cz> References: <20171222084623.668990192@linuxfoundation.org> <20171222084625.007160464@linuxfoundation.org> <1515302062.6507.18.camel@gmx.de> <20180107091115.GB29329@kroah.com> <20180107101847.GC24862@dhcp22.suse.cz> <1515329042.13953.14.camel@gmx.de> <20180107132309.GD24862@dhcp22.suse.cz> <20180108075308.GC24062@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180108075308.GC24062@kroah.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon 08-01-18 08:53:08, Greg KH wrote: > On Sun, Jan 07, 2018 at 02:23:09PM +0100, Michal Hocko wrote: > > On Sun 07-01-18 13:44:02, Mike Galbraith wrote: > > > On Sun, 2018-01-07 at 11:18 +0100, Michal Hocko wrote: > > > > On Sun 07-01-18 10:11:15, Greg KH wrote: > > > > > On Sun, Jan 07, 2018 at 06:14:22AM +0100, Mike Galbraith wrote: > > > > > > On Fri, 2017-12-22 at 09:45 +0100, Greg Kroah-Hartman wrote: > > > > > > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > > > FYI, this broke kdump, or rather the makedumpfile part thereof. > > > > > > ?Forward looking wreckage is par for the kdump course, but... > > > > > > > > > > Is it also broken in Linus's tree with this patch? Or is there an > > > > > add-on patch that I should apply to 4.14 to resolve this issue there? > > > > > > > > This one http://lkml.kernel.org/r/1513932498-20350-1-git-send-email-bhe@redhat.com > > > > I guess. > > > > > > That won't unbreak kdump, else master wouldn't be broken. ?I don't care > > > deeply, or know if anyone else does, I'm just reporting it because I > > > met it and chased it down. > > > > OK, I didn't notice that d8cfbbfa0f7 ("mm/sparse.c: wrong allocation > > for mem_section") made it in after rc6. I am still wondering why > > 83e3c48729 ("mm/sparsemem: Allocate mem_section at runtime for > > CONFIG_SPARSEMEM_EXTREME=y") made it into the stable tree in the first > > place. > > It was part of the prep for the KTPI code from what I can tell. I do not see a direct relation, to be honest. It is more related to 5-level page tables but I might be missing some subtle relation. > If you > think it should be reverted, just let me know and I'll be glad to do so. This seems to be affecting Linus tree as well so it needs to get resolved. I would suggest reverting in stable for the mean time. If you really need it in the stable tree then you can pull it back later with all the follow up fixes. -- Michal Hocko SUSE Labs