Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756070AbeAHIxd (ORCPT + 1 other); Mon, 8 Jan 2018 03:53:33 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:43161 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755984AbeAHIxc (ORCPT ); Mon, 8 Jan 2018 03:53:32 -0500 X-Google-Smtp-Source: ACJfBov/eetN8FV/1y0exgP+OZ2pvn1rBOWWjgE0so0W6cgzeeShUNnnmHFbLndF4pwHKbvy7dHG3Q== Subject: Re: [PATCH v2 3/6] clocksource/drivers: atmel-pit: allow unselecting ATMEL_PIT To: Boris Brezillon Cc: Alexandre Belloni , Thomas Gleixner , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20180105143006.5369-1-alexandre.belloni@free-electrons.com> <20180105143006.5369-4-alexandre.belloni@free-electrons.com> <64398ab7-fbc6-0313-ccc6-51ff02d087e6@linaro.org> <20180107184455.GG5545@piout.net> <20180108092255.7e0f9f07@bbrezillon> From: Daniel Lezcano Message-ID: <0d0040a6-cbf5-e247-f9a0-a0a8c4a030c1@linaro.org> Date: Mon, 8 Jan 2018 09:53:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180108092255.7e0f9f07@bbrezillon> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 08/01/2018 09:22, Boris Brezillon wrote: > On Mon, 8 Jan 2018 08:23:02 +0100 > Daniel Lezcano wrote: > >> On 07/01/2018 19:44, Alexandre Belloni wrote: >>> On 07/01/2018 at 19:07:13 +0100, Daniel Lezcano wrote: >>>> On 05/01/2018 15:30, Alexandre Belloni wrote: >>>>> With the new TCB clocksource driver, atmel platforms are now able to boot >>>>> without the PIT driver. Allow unselecting it. >>>>> >>>>> Signed-off-by: Alexandre Belloni >>>>> --- >>>>> drivers/clocksource/Kconfig | 9 ++++++++- >>>>> 1 file changed, 8 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >>>>> index 5609572e0236..55ccfa0ba63b 100644 >>>>> --- a/drivers/clocksource/Kconfig >>>>> +++ b/drivers/clocksource/Kconfig >>>>> @@ -381,7 +381,14 @@ config ARMV7M_SYSTICK >>>>> >>>>> config ATMEL_PIT >>>>> select TIMER_OF if OF >>>>> - def_bool SOC_AT91SAM9 || SOC_SAMA5 >>>>> + bool "Atmel Periodic Interval Timer (PIT)" >>>>> + depends on SOC_AT91SAM9 || SOC_SAMA5 >>>>> + default SOC_AT91SAM9 || SOC_SAMA5 >>>>> + help >>>>> + Select this to get a clocksource based on the Atmel Periodic Interval >>>>> + Timer. It has a relatively low resolution and the TC Block clocksource >>>>> + should be preferred. >>>>> + It also provides a clock event device. >>>> >>>> Please conform to the format: >>>> >>>> config ATMEL_PIT >>>> bool "Atmel Periodic Interval Timer (PIT)" if COMPILE_TEST >>>> select ... >>>> help >>>> bla bla >>>> >>>> and select ATMEL_PIT from the platform's Kconfig. >>>> >>> >>> Well, the goal is actually to allow people to unselect it so we don't >>> want the platform to select it. >> >> Why do you need people to unselect it? > > Because we have 2 possible clocksource for atmel platforms: the PIT or > the TCB, if the TCB is selected there's no point in compiling the PIT > driver. Why the platform's Kconfig can't do that ? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog