Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756304AbeAHKi0 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 05:38:26 -0500
Received: from mx2.suse.de ([195.135.220.15]:50518 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755200AbeAHKiY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 05:38:24 -0500
Message-ID: <1515407612.29712.1.camel@suse.com>
Subject: Re: [PATCH v2 1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL
 ioctl case.
From: Oliver Neukum <oneukum@suse.com>
To: Mikhail Zaytsev <flashed@mail.ru>, Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Date: Mon, 08 Jan 2018 11:33:32 +0100
In-Reply-To: <20180106201402.03d2ac88@debian>
References: <20180106200809.41cdd723@debian>
         <20180106201402.03d2ac88@debian>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Am Samstag, den 06.01.2018, 20:14 +0300 schrieb Mikhail Zaytsev:
> The patch removes unused TIOCSSERIAL ioctl case and adds the default block
> to the switch. This will make the ioctl return -ENOTTY to user space (e.g.
> setserial), because TIOCSSERIAL really isn't supported for these devices
> currently.

Hi,

this will break software that is now running on these devices,
won't it? Do you know why those devices basically ignore the
ioctl?

	Regards
		Oliver