Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756673AbeAHKvI (ORCPT + 1 other); Mon, 8 Jan 2018 05:51:08 -0500 Received: from mga04.intel.com ([192.55.52.120]:14727 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756343AbeAHKvG (ORCPT ); Mon, 8 Jan 2018 05:51:06 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="8142930" Date: Mon, 8 Jan 2018 16:25:15 +0530 From: Vinod Koul To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com, joabreu@synopsys.com, mike.looijmans@topic.nl, kedare06@gmail.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] dmaengine: xilinx_dma: properly configure the SG mode bit in the driver for cdma Message-ID: <20180108105515.GG18649@localhost> References: <1514961731-1916-1-git-send-email-appanad@xilinx.com> <1514961731-1916-3-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514961731-1916-3-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 03, 2018 at 12:12:09PM +0530, Kedareswara rao Appana wrote: > If the hardware is configured for Scatter Gather(SG) mode, > and hardware is idle, in the control register SG mode bit > must be set to a 0 then back to 1 by the software, to force > the CDMA SG engine to use a new value written to the CURDESC_PNTR > register, failure to do so could result errors from the dmaengine. Applied 2-4, thanks -- ~Vinod