Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932412AbeAHLzm (ORCPT + 1 other); Mon, 8 Jan 2018 06:55:42 -0500 Received: from mga04.intel.com ([192.55.52.120]:17624 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932363AbeAHLzk (ORCPT ); Mon, 8 Jan 2018 06:55:40 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="asc'?scan'208";a="9509644" From: Felipe Balbi To: Lipengcheng Cc: "gregkh\@linuxfoundation.org" , "linux-kernel\@vger.kernel.org" , "linux-usb\@vger.kernel.org" , Lipengcheng , Laurent Pinchart (maintainer:USB WEBCAM GADGET) Subject: Re: [PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value In-Reply-To: <637796ED17F7774FB27D6AAE3C6951584B38D3F6@dggeml508-mbx.china.huawei.com> References: <637796ED17F7774FB27D6AAE3C6951584B38D3F6@dggeml508-mbx.china.huawei.com> Date: Mon, 08 Jan 2018 13:54:15 +0200 Message-ID: <874lnwlg60.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Lipengcheng writes: > The value is 4, it can cache four descriptors. When streaming_interval = =3D 1, > it can tolerate 500us. Some busy scenes, it may be more than 500us because > cpu scheduling is not timely. There will have some problems. It is better > set to eight. > > Signed-off-by: Pengcheng Li > --- > drivers/usb/gadget/function/uvc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/uvc.h b/drivers/usb/gadget/funct= ion/uvc.h > index a64e07e..901487e 100644 > --- a/drivers/usb/gadget/function/uvc.h > +++ b/drivers/usb/gadget/function/uvc.h > @@ -90,7 +90,7 @@ extern unsigned int uvc_gadget_trace_param; > * Driver specific constants > */ > > -#define UVC_NUM_REQUESTS 4 > +#define UVC_NUM_REQUESTS 8 if you want to be taken seriously, the bare minimum you can do is to use scripts/get_maintainer.pl to help with a proper Cc list: $ scripts/get_maintainer.pl -f drivers/usb/gadget/function/uvc.h Laurent Pinchart (maintainer:USB WEBCAM= GADGET) Felipe Balbi (maintainer:USB GADGET/PERIPHERAL SUBSYSTEM) Greg Kroah-Hartman (supporter:USB SUBSYSTEM) linux-usb@vger.kernel.org (open list:USB WEBCAM GADGET) linux-kernel@vger.kernel.org (open list) Laurent, what do you think about this? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlpTW+cACgkQzL64meEa mQaptg//d+4fBtVBQR33d4+pz0TU8ghXddOVozoVSQ6fMlzW7jsvT3PvZ2ITFwZS jFJK4i3SH9pEaM8M+R+TSvK0xulSaYLWAqsQGRdXf9YhAKHz5Hez1whWunoJL5PL a3tTBjojtSibMNmUPrY0B7FuXgsjbOzGQ0CEMqpJWCOVbZc+qrqei8yOpeNuvyNq hNc0wscmMfW/mLYk9Iu2wYonNhexImyExf27ETdjTQ3v5CpUa/vPNaVbNLl8BGSa z8+LO2tBbGmnd8aW16ZCSOuCrexku2uiSDNnkHodB8r3SUsj18SLN/e2qTgOlk2T NwAi/MzOtIUWJFsUPjbscVHGnNmAgzIsjl/cGmT1b4T60mnaJvoBaVXfte6F1Zyf kOGduOB7yxHozMN2lLfsg9VNihcHy9tEe2CCZCSixWGPFuW05b/17g/32WKYPJ43 BIT4dN79GbHvJ+yUg9AVhe7HMJb1cISsjBzbjNZhMtl7Hc1KSDcYTgUOf9f2y3cR 2IZyQIlqlWrZtEu6NiClPSNdnOXB7HTx07UfCPmi5UQ7Kg81UliFZCtVRA+36/e4 +VC6ZXrILqcLHZqqx1APhn+od3/U049oICjXwtxoL7SF1Olt2Rv8iKQujLLdqZtp WjAjl62TWQE/G9dkfV5mgQ5SdLjwNo+vipfK7DiVx9nOniqj9Bs= =+Z5m -----END PGP SIGNATURE----- --=-=-=--