Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756918AbeAHMMY (ORCPT + 1 other); Mon, 8 Jan 2018 07:12:24 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3755 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756426AbeAHMMW (ORCPT ); Mon, 8 Jan 2018 07:12:22 -0500 From: Xiongfeng Wang To: CC: , , Subject: [PATCH] fs/hfsplus: use memcpy() instead of strncpy() Date: Mon, 8 Jan 2018 20:17:37 +0800 Message-ID: <1515413857-48430-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Xiongfeng Wang gcc-8 reports inlined from 'copy_name' at fs/hfsplus/xattr.c:416:3: ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] Since we don't need to copy '\0', we can just use memcpy() to avoid this warning. Signed-off-by: Xiongfeng Wang --- fs/hfsplus/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c index e538b75..0dc8a65 100644 --- a/fs/hfsplus/xattr.c +++ b/fs/hfsplus/xattr.c @@ -413,7 +413,7 @@ static int copy_name(char *buffer, const char *xattr_name, int name_len) int offset = 0; if (!is_known_namespace(xattr_name)) { - strncpy(buffer, XATTR_MAC_OSX_PREFIX, XATTR_MAC_OSX_PREFIX_LEN); + memcpy(buffer, XATTR_MAC_OSX_PREFIX, XATTR_MAC_OSX_PREFIX_LEN); offset += XATTR_MAC_OSX_PREFIX_LEN; len += XATTR_MAC_OSX_PREFIX_LEN; } -- 1.8.3.1