Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757215AbeAHM3G (ORCPT + 1 other); Mon, 8 Jan 2018 07:29:06 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:34788 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757183AbeAHM3F (ORCPT ); Mon, 8 Jan 2018 07:29:05 -0500 From: Xiongfeng Wang To: CC: , Subject: [PATCH] test_hexdump: use memcpy() to avoid warning print Date: Mon, 8 Jan 2018 20:34:17 +0800 Message-ID: <1515414857-182589-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Xiongfeng Wang gcc-8 reports lib/test_hexdump.c: In function 'test_hexdump_prepare_test.isra.0': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output truncated copying between 0 and 32 bytes from a string of length 32 [-Wstringop-truncation] Since we don't need to copy '\0' in the end of the string, we can just use memcpy() to avoid this warning. Signed-off-by: Xiongfeng Wang --- lib/test_hexdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c index 3f415d8..a495726 100644 --- a/lib/test_hexdump.c +++ b/lib/test_hexdump.c @@ -81,7 +81,7 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize, const char *q = *result++; size_t amount = strlen(q); - strncpy(p, q, amount); + memcpy(p, q, amount); p += amount; *p++ = ' '; @@ -95,7 +95,7 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize, *p++ = ' '; } while (p < test + rs * 2 + rs / gs + 1); - strncpy(p, data_a, l); + memcpy(p, data_a, l); p += l; } -- 1.8.3.1