Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756891AbeAHM5r (ORCPT + 1 other); Mon, 8 Jan 2018 07:57:47 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34116 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756091AbeAHM5p (ORCPT ); Mon, 8 Jan 2018 07:57:45 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 08 Jan 2018 13:57:45 +0100 From: haver To: "Guilherme G. Piccoli" Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org Subject: Re: [PATCH 0/3] Some small clean-ups in genwqe In-Reply-To: <20171214143406.14652-1-gpiccoli@linux.vnet.ibm.com> References: <20171214143406.14652-1-gpiccoli@linux.vnet.ibm.com> User-Agent: Roundcube Webmail/1.0.1 X-TM-AS-GCONF: 00 x-cbid: 18010812-0008-0000-0000-000002BBD6D7 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008339; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000245; SDB=6.00972009; UDB=6.00492387; IPR=6.00751960; BA=6.00005767; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018922; XFM=3.00000015; UTC=2018-01-08 12:57:41 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18010812-0009-0000-0000-000037D60153 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-08_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801080188 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Guilherme, On 2017-12-14 15:34, Guilherme G. Piccoli wrote: > This patchset is composed by 3 small clean-ups to genwqe > driver. It aims to improve code clarity, by removing unused > stuff and make the code follow some conventions. > > It was built and tested against v4.15-rc3, and aims merge > in v4.16 if possible. > > Thanks in advance! > > Guilherme G. Piccoli (3): > genwqe: Remove unused variable and rename function > genwqe: Make defines uppercase > genwqe: Remove unused parameter in some functions > > drivers/misc/genwqe/card_base.c | 16 ++++++++-------- > drivers/misc/genwqe/card_base.h | 20 +++++++++----------- > drivers/misc/genwqe/card_ddcb.c | 22 +++++++++++----------- > drivers/misc/genwqe/card_debugfs.c | 2 +- > drivers/misc/genwqe/card_dev.c | 19 ++++++++----------- > drivers/misc/genwqe/card_utils.c | 25 +++++++++---------------- > 6 files changed, 46 insertions(+), 58 deletions(-) Looks ok to me. Thanks for the contribution. Regards Frank Acked-by: Frank Haverkamp