Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756654AbeAHNmx (ORCPT + 1 other); Mon, 8 Jan 2018 08:42:53 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42232 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755200AbeAHNmv (ORCPT ); Mon, 8 Jan 2018 08:42:51 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 08 Jan 2018 14:42:49 +0100 From: haver To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , "Guilherme G. Piccoli" , LKML , =?UTF-8?Q?J=C3=B6rg-Stephan_Vogt?= , Michael Jung , =?UTF-8?Q?Michael_R=C3=BCttger?= Subject: Re: [PATCH 1/3] GenWQE: Delete an error message for a failed memory allocation in genwqe_user_vmap() In-Reply-To: References: <127e28a8a4d9081eb323e3c7ab93dad0@linux.vnet.ibm.com> User-Agent: Roundcube Webmail/1.0.1 X-TM-AS-GCONF: 00 x-cbid: 18010813-0024-0000-0000-0000030DDC07 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008340; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000245; SDB=6.00972024; UDB=6.00492396; IPR=6.00751974; BA=6.00005767; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018923; XFM=3.00000015; UTC=2018-01-08 13:42:47 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18010813-0025-0000-0000-0000468F3A53 Message-Id: <6aa7eaf36fe5fff4849f4eec4d62051a@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-08_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801080198 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 2018-01-08 14:24, SF Markus Elfring wrote: >>> @@ -593,7 +593,6 @@ int genwqe_user_vmap(struct genwqe_dev *cd, >>> struct >>> dma_mapping *m, void *uaddr, >>>                     sizeof(struct page *) + >>> sizeof(dma_addr_t), >>>                     GFP_KERNEL); >>>      if (!m->page_list) { >>> -        dev_err(&pci_dev->dev, "err: alloc page_list >>> failed\n"); >> >> Are there different printouts which cover this? > > Is this error message redundant? > > >> I mean the debug printout is not appearing all the time, >> it must be enabled, if I remember correctly. > > Would you like to clarify corresponding configuration possibilities any > more? > > >> So why do you suggest to remove it? > > Can the Linux allocation failure report be sufficient for this use case > already? > > Regards, > Markus According to Dans message in parallel, it should be redundant and I am fine with removing it. Acked-by: Frank Haverkamp