Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934365AbeAHPzt (ORCPT + 1 other); Mon, 8 Jan 2018 10:55:49 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:48950 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934187AbeAHPzq (ORCPT ); Mon, 8 Jan 2018 10:55:46 -0500 Subject: Re: [PATCH v2] x86: xen: remove the use of VLAIS To: Nick Desaulniers , Juergen Gross Cc: ghackmann@google.com, mka@google.com, kees@google.com, srhines@google.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <1515274788-24548-1-git-send-email-nick.desaulniers@gmail.com> From: Boris Ostrovsky Message-ID: <37fc26d2-734a-4690-d4f2-6d0df82015a4@oracle.com> Date: Mon, 8 Jan 2018 10:54:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1515274788-24548-1-git-send-email-nick.desaulniers@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8768 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801080227 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/06/2018 04:39 PM, Nick Desaulniers wrote: > Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and > frowned upon by others. > > https://lkml.org/lkml/2013/9/23/500 > > Here, the VLAIS was used because the size of the bitmap returned from > xen_mc_entry() depended on possibly (based on kernel configuration) > runtime sized data. Rather than declaring args as a VLAIS then calling > sizeof on *args, we calculate the appropriate sizeof args manually. > Further, we can get rid of the #ifdef's and rely on num_possible_cpus() > (thanks to a helpful checkpatch warning from an earlier version of this > patch). > > Suggested-by: Juergen Gross > Signed-off-by: Nick Desaulniers Applied to for-linus-4.15. -boris