Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934744AbeAHQVe (ORCPT + 1 other); Mon, 8 Jan 2018 11:21:34 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43502 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756259AbeAHQV3 (ORCPT ); Mon, 8 Jan 2018 11:21:29 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C754960346 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post From: Kalle Valo In-Reply-To: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> References: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: colin.king@canonical.com, johannes.berg@intel.com, tiwai@suse.de, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, andrew.zaborowski@intel.com, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180108162128.C4C9060B3B@smtp.codeaurora.org> Date: Mon, 8 Jan 2018 16:21:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Jia-Ju Bai wrote: > b43_radio_2057_init_post is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai You submitted an identical patch a week earlier: https://patchwork.kernel.org/patch/10137671/ How is this different? Also always add version number to the patch so that the maintainers can follow the changes easily: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing -- https://patchwork.kernel.org/patch/10137671/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches