Subject: Re: [PATCH v2] x86: xen: remove the use of VLAIS
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Nick Desaulniers <nick.desaulniers@gmail.com>
Cc: ghackmann@google.com, mka@google.com, kees@google.com,
        srhines@google.com, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <c2217783-9d18-912f-8c13-996489dbe602@suse.com>
 <1515274788-24548-1-git-send-email-nick.desaulniers@gmail.com>
 <20180108161001.GM32035@hirez.programming.kicks-ass.net>
 <0745372f-93af-3b70-e82d-db75af32742a@oracle.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <62287687-99c2-b306-d1fc-7dc87fd38eb6@suse.com>
Date: Mon, 8 Jan 2018 17:28:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <0745372f-93af-3b70-e82d-db75af32742a@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 08/01/18 17:20, Boris Ostrovsky wrote:
> On 01/08/2018 11:10 AM, Peter Zijlstra wrote:
>> On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote:
>>> Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and
>>> frowned upon by others.
>>>
>>> https://lkml.org/lkml/2013/9/23/500
>>>
>>> Here, the VLAIS was used because the size of the bitmap returned from
>>> xen_mc_entry() depended on possibly (based on kernel configuration)
>>> runtime sized data. Rather than declaring args as a VLAIS then calling
>>> sizeof on *args, we calculate the appropriate sizeof args manually.
>>> Further, we can get rid of the #ifdef's and rely on num_possible_cpus()
>>> (thanks to a helpful checkpatch warning from an earlier version of this
>>> patch).
>>>
>>> Suggested-by: Juergen Gross <jgross@suse.com>
>>> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
>>> ---
>>> Changes in v2:
>>> * Change mask to us DECLARE_BITMAP instead of pointer, as suggested.
>>> * Update commit message to remove mention of pointer.
>>> * Update sizeof calculation to work with array rather than pointer.
>>>
>>>  arch/x86/xen/mmu_pv.c | 8 +++-----
>>>  1 file changed, 3 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
>>> index 4d62c07..d850762 100644
>>> --- a/arch/x86/xen/mmu_pv.c
>>> +++ b/arch/x86/xen/mmu_pv.c
>>> @@ -1325,20 +1325,18 @@ static void xen_flush_tlb_others(const struct cpumask *cpus,
>>>  {
>>>  	struct {
>>>  		struct mmuext_op op;
>>> -#ifdef CONFIG_SMP
>>> -		DECLARE_BITMAP(mask, num_processors);
>>> -#else
>>>  		DECLARE_BITMAP(mask, NR_CPUS);
>>> -#endif
>>>  	} *args;
>> Why is it OK for Xen to place this bitmap on-stack in the first place?
>> That NR_CPUS thing can be fairly huge.
> 
> Err... right. Now it's even worse than it was before, when the array was
> potentially smaller. I'll drop this.

No, its only the pointer to the struct, not the struct itself.


Juergen