Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933157AbeAHQcC (ORCPT + 1 other); Mon, 8 Jan 2018 11:32:02 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:41854 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932182AbeAHQb6 (ORCPT ); Mon, 8 Jan 2018 11:31:58 -0500 X-Google-Smtp-Source: ACJfBoun1SvL/dohn8u68E26QWEhYvsO13Cp9I9WNJHC+QzqJRpDEtBz3VYCc7a4/j8z/n4S60l9Lg== Subject: Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post To: Kalle Valo , Jia-Ju Bai Cc: kstewart@linuxfoundation.org, johannes.berg@intel.com, tiwai@suse.de, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, andrew.zaborowski@intel.com, b43-dev@lists.infradead.org, netdev@vger.kernel.org, colin.king@canonical.com References: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> <20180108162128.6D37560B1D@smtp.codeaurora.org> From: Larry Finger Message-ID: Date: Mon, 8 Jan 2018 10:31:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180108162128.6D37560B1D@smtp.codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/08/2018 10:21 AM, Kalle Valo wrote: > Jia-Ju Bai wrote: > >> b43_radio_2057_init_post is not called in an interrupt handler >> nor holding a spinlock. >> The function mdelay in it can be replaced with msleep, to reduce busy wait. >> >> Signed-off-by: Jia-Ju Bai > > You submitted an identical patch a week earlier: > > https://patchwork.kernel.org/patch/10137671/ > > How is this different? Also always add version number to the patch so that the > maintainers can follow the changes easily: > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing I had negative comments on one of those due to the possibility of msleep(2) extending as long as 20 msec. Until the author, or someone else, can test that this is OK, then the mdelay(2) can only be replaced with usleep_range(2000, 3000). NACK for both. Larry