Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934060AbeAHQvo (ORCPT + 1 other); Mon, 8 Jan 2018 11:51:44 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:42030 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932675AbeAHQvn (ORCPT ); Mon, 8 Jan 2018 11:51:43 -0500 X-Google-Smtp-Source: ACJfBostCysB14GftYfu4uHmG+B5w8J68Q3MCBFz3V3dOG0TS97gCsXP/+YQaGVMRWXT4YPX0F6KPfdEdIkVyE8Zuxg= MIME-Version: 1.0 In-Reply-To: <20180108161435.e3jjrttk57lib63a@gmail.com> References: <20171123165226.32582-1-aneesh.kumar@linux.vnet.ibm.com> <20180108161435.e3jjrttk57lib63a@gmail.com> From: Philippe Ombredanne Date: Mon, 8 Jan 2018 17:51:01 +0100 Message-ID: Subject: Re: [PATCH v4] selftest/vm: Move the 128 TB mmap boundary test to the generic VM directory To: "Aneesh Kumar K.V" Cc: "Kirill A . Shutemov" , Ingo Molnar , Andrew Morton , Ingo Molnar , x86@kernel.org, Thomas Gleixner , "H . Peter Anvin" , linux-mm@kvack.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Anesh, On Mon, Jan 8, 2018 at 5:14 PM, Ingo Molnar wrote: > > * Aneesh Kumar K.V wrote: > >> Architectures like ppc64 do support mmap hint addr based large address space >> selection. This test can be run on those architectures too. Move the test to >> selftest/vm so that other archs can use the same. >> >> We also add a few new test scenarios in this patch. We do test few boundary >> condition before we do a high address mmap. ppc64 use the addr limit to validate >> addr in the fault path. We had bugs in this area w.r.t slb fault handling >> before we updated the addr limit. >> >> We also touch the allocated space to make sure we don't have any bugs in the >> fault handling path. >> >> Signed-off-by: Aneesh Kumar K.V > --- /dev/null > +++ b/tools/testing/selftests/vm/va_128TBswitch.c > @@ -0,0 +1,297 @@ > +/* > + * > + * Authors: Kirill A. Shutemov > + * Authors: Aneesh Kumar K.V > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License, version 2, as > + * published by the Free Software Foundation. > + > + * This program is distributed in the hope that it would be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > + * > + */ Would you mind using an SPDX tag instead of this fine legalese? See Thomas doc [1] for details. Thanks! [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne