Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933263AbeAHTc7 (ORCPT + 1 other); Mon, 8 Jan 2018 14:32:59 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47064 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932835AbeAHTc6 (ORCPT ); Mon, 8 Jan 2018 14:32:58 -0500 Date: Mon, 08 Jan 2018 14:32:56 -0500 (EST) Message-Id: <20180108.143256.2300624650207352851.davem@davemloft.net> To: laoar.shao@gmail.com Cc: songliubraving@fb.com, brendan.d.gregg@gmail.com, marcelo.leitner@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next] net: tracepoint: exposing sk_faimily in tracepoint inet_sock_set_state From: David Miller In-Reply-To: <1515306707-1759-1-git-send-email-laoar.shao@gmail.com> References: <1515306707-1759-1-git-send-email-laoar.shao@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Jan 2018 11:32:58 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Yafang Shao Date: Sun, 7 Jan 2018 14:31:47 +0800 > As of now, there're two sk_family are traced with sock:inet_sock_set_state, > which are AF_INET and AF_INET6. > So the sk_family are exposed as well. > Then we can conveniently use it to do the filter. > > Both sk_family and sk_protocol are showed in the printk message, so we need > not expose them as tracepoint arguments. > > Suggested-by: Brendan Gregg > Suggested-by: Song Liu > Signed-off-by: Yafang Shao Applied, thank you.