Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753911AbeAHUEl (ORCPT + 1 other); Mon, 8 Jan 2018 15:04:41 -0500 Received: from mx3.wp.pl ([212.77.101.9]:56493 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753193AbeAHUEj (ORCPT ); Mon, 8 Jan 2018 15:04:39 -0500 Date: Mon, 8 Jan 2018 12:04:31 -0800 From: Jakub Kicinski To: Peng Li Cc: , , , , Subject: Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev Message-ID: <20180108120431.1e4b45e1@cakuba.netronome.com> In-Reply-To: <1515147504-86802-13-git-send-email-lipeng321@huawei.com> References: <1515147504-86802-1-git-send-email-lipeng321@huawei.com> <1515147504-86802-13-git-send-email-lipeng321@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 887d718de34ce9e2c613f185df7d29e0 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [gQOE] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, 5 Jan 2018 18:18:16 +0800, Peng Li wrote: > +static const struct hns3_stats hns3_netdev_stats[] = { > + /* Rx per-queue statistics */ > + HNS3_NETDEV_STAT("rx_packets", rx_packets), > + HNS3_NETDEV_STAT("tx_packets", tx_packets), > + HNS3_NETDEV_STAT("rx_bytes", rx_bytes), > + HNS3_NETDEV_STAT("tx_bytes", tx_bytes), > + HNS3_NETDEV_STAT("rx_errors", rx_errors), > + HNS3_NETDEV_STAT("tx_errors", tx_errors), > + HNS3_NETDEV_STAT("rx_dropped", rx_dropped), > + HNS3_NETDEV_STAT("tx_dropped", tx_dropped), > + HNS3_NETDEV_STAT("multicast", multicast), > + HNS3_NETDEV_STAT("collisions", collisions), > + HNS3_NETDEV_STAT("rx_length_errors", rx_length_errors), > + HNS3_NETDEV_STAT("rx_over_errors", rx_over_errors), > + HNS3_NETDEV_STAT("rx_crc_errors", rx_crc_errors), > + HNS3_NETDEV_STAT("rx_frame_errors", rx_frame_errors), > + HNS3_NETDEV_STAT("rx_fifo_errors", rx_fifo_errors), > + HNS3_NETDEV_STAT("rx_missed_errors", rx_missed_errors), > + HNS3_NETDEV_STAT("tx_aborted_errors", tx_aborted_errors), > + HNS3_NETDEV_STAT("tx_carrier_errors", tx_carrier_errors), > + HNS3_NETDEV_STAT("tx_fifo_errors", tx_fifo_errors), > + HNS3_NETDEV_STAT("tx_heartbeat_errors", tx_heartbeat_errors), > + HNS3_NETDEV_STAT("tx_window_errors", tx_window_errors), > + HNS3_NETDEV_STAT("rx_compressed", rx_compressed), > + HNS3_NETDEV_STAT("tx_compressed", tx_compressed), > +}; Ugh, I so didn't review this in time :( I think there is a consensus that we should avoid duplicating standard stats in ethtool. Especially those old ones. Like "collisions", I assume this is a modern NIC, are collisions still a thing?