Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932228AbeAIBjT (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 20:39:19 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:51628 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753952AbeAIBjR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 20:39:17 -0500
Date: Mon, 08 Jan 2018 20:39:13 -0500 (EST)
Message-Id: <20180108.203913.1283013651432416478.davem@davemloft.net>
To: kubakici@wp.pl
Cc: lipeng321@huawei.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxarm@huawei.com,
        salil.mehta@huawei.com
Subject: Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of
 netdev
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180108120431.1e4b45e1@cakuba.netronome.com>
References: <1515147504-86802-1-git-send-email-lipeng321@huawei.com>
        <1515147504-86802-13-git-send-email-lipeng321@huawei.com>
        <20180108120431.1e4b45e1@cakuba.netronome.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Jan 2018 17:39:17 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

From: Jakub Kicinski <kubakici@wp.pl>
Date: Mon, 8 Jan 2018 12:04:31 -0800

> Ugh, I so didn't review this in time :(  I think there is a consensus
> that we should avoid duplicating standard stats in ethtool.  Especially
> those old ones.  Like "collisions", I assume this is a modern NIC, are
> collisions still a thing?

There is no standard way to get per-queue values, and ethtool stats are
how pretty much every driver provides it.