Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933247AbeAIByn (ORCPT + 1 other); Mon, 8 Jan 2018 20:54:43 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51784 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932573AbeAIBym (ORCPT ); Mon, 8 Jan 2018 20:54:42 -0500 Date: Mon, 08 Jan 2018 20:54:40 -0500 (EST) Message-Id: <20180108.205440.1825662768273316692.davem@davemloft.net> To: kubakici@wp.pl Cc: lipeng321@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com Subject: Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev From: David Miller In-Reply-To: <20180108175021.4a769c33@cakuba.netronome.com> References: <20180108.203913.1283013651432416478.davem@davemloft.net> <20180108174602.34bee66b@cakuba.netronome.com> <20180108175021.4a769c33@cakuba.netronome.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Jan 2018 17:54:42 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Jakub Kicinski Date: Mon, 8 Jan 2018 17:50:21 -0800 > Oh, I only noticed this extra misleading comment now. Unless each queue > has a netdev, I don't see how these are per-queue. If it isn't per-queue I want this change reverted.