Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757995AbeAICDo (ORCPT + 1 other); Mon, 8 Jan 2018 21:03:44 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:40478 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757780AbeAICDj (ORCPT ); Mon, 8 Jan 2018 21:03:39 -0500 X-Google-Smtp-Source: ACJfBovAYrY8tQ/0/eFs/H0Kxd/BR0BdZq78cYhzCBuR30/yd6fHy+pTCl0+EujAFXfwOEvuLRjvGA== From: Jonathan Liu To: Maxime Ripard , David Airlie , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Jonathan Liu Subject: [PATCH v3 2/3] drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate Date: Tue, 9 Jan 2018 13:03:22 +1100 Message-Id: <20180109020323.11852-3-net147@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180109020323.11852-1-net147@gmail.com> References: <20180109020323.11852-1-net147@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: best_div is set to i which corresponds to rate halving when it should be set to j which corresponds to the divider. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index 4d235e5ea31c..88eeeaf34638 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c @@ -105,7 +105,7 @@ static int sun4i_tmds_determine_rate(struct clk_hw *hw, if (!best_parent || abs(rate - rounded / i) < abs(rate - best_parent / best_div)) { best_parent = rounded; - best_div = i; + best_div = j; } } } -- 2.15.1