Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754749AbeAICsb (ORCPT + 1 other); Mon, 8 Jan 2018 21:48:31 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3703 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754049AbeAICsa (ORCPT ); Mon, 8 Jan 2018 21:48:30 -0500 Subject: Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev To: David Miller , References: <20180108.203913.1283013651432416478.davem@davemloft.net> <20180108174602.34bee66b@cakuba.netronome.com> <20180108175021.4a769c33@cakuba.netronome.com> <20180108.205440.1825662768273316692.davem@davemloft.net> CC: , , , From: "lipeng (Y)" Message-ID: <937b5edd-8b05-56db-5510-6d09b0004a0b@huawei.com> Date: Tue, 9 Jan 2018 10:48:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20180108.205440.1825662768273316692.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.63.173.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 2018/1/9 9:54, David Miller wrote: > From: Jakub Kicinski > Date: Mon, 8 Jan 2018 17:50:21 -0800 > >> Oh, I only noticed this extra misleading comment now. Unless each queue >> has a netdev, I don't see how these are per-queue. > If it isn't per-queue I want this change reverted. [patch 12/20 ] add statistics of netdev for ethtool -S, netdev may have multi queue. As discussion here, it is duplicate to add this patch. I revert [patch 12/20 ] , and then test on my board, HNS3 basic function and ethtool -S work well. So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev"). Thanks Peng Li > . >