Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756287AbeAIDjm (ORCPT + 1 other); Mon, 8 Jan 2018 22:39:42 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34451 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756155AbeAIDjk (ORCPT ); Mon, 8 Jan 2018 22:39:40 -0500 X-Google-Smtp-Source: ACJfBou8cBiJArnnj8+2vgwHhS/gb++5223+Xaw+GPTGb1cOB+D3l5Dng+qXjEBz//TmdOlPeTj5lQ== Date: Mon, 8 Jan 2018 19:39:37 -0800 From: Richard Cochran To: Yangbo Lu Cc: Fabio Estevam , Claudiu Manoil , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2] net: gianfar_ptp: move set_fipers() to spinlock protecting area Message-ID: <20180109033937.fnppxraqb7ylikdg@localhost> References: <20180109030233.16013-1-yangbo.lu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180109030233.16013-1-yangbo.lu@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 09, 2018 at 11:02:33AM +0800, Yangbo Lu wrote: > set_fipers() calling should be protected by spinlock in > case that any interrupt breaks related registers setting > and the function we expect. This patch is to move set_fipers() > to spinlock protecting area in ptp_gianfar_adjtime(). > > Signed-off-by: Yangbo Lu Acked-by: Richard Cochran