Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757479AbeAIERP (ORCPT + 1 other); Mon, 8 Jan 2018 23:17:15 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:32844 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753658AbeAIERN (ORCPT ); Mon, 8 Jan 2018 23:17:13 -0500 X-Google-Smtp-Source: ACJfBovfV4StveNJBCnaF2h4X2eniXPKulOJAmpNCyekcwMsE/jiMEBk9C2R5GYabQ+9jczVA3p/sw== Date: Mon, 8 Jan 2018 22:17:10 -0600 From: Rob Herring To: Matthias Kaehlcke Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Mark Rutland , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bhumika Goyal , Arnaud Pouliquen , huang lin , Brian Norris , Dylan Reid Subject: Re: [PATCH] ASoC: codecs: dmic: Make number of channels configurable Message-ID: <20180109041710.xjnyjvkxkrqhgnlg@rob-hp-laptop> References: <20180105203957.184883-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180105203957.184883-1-mka@chromium.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Jan 05, 2018 at 12:39:57PM -0800, Matthias Kaehlcke wrote: > The DMIC DAI driver specifies a number of 1 to 8 channels for each DAI. > The actual number of mics can currently not be configured in the device > tree or audio glue, but is derived from the min/max channels of the CPU > and codec DAI. A typical CPU DAI has two or more channels, in consequence > a single mic is treated as a stereo/multi channel device, even though > only one channel carries audio data. > > This change adds the option to specify the number of used DMIC channels > in the device tree. When specified this value overwrites the default > channels_max value of 8 in the snd_soc_dai_driver struct of the codec. > > Signed-off-by: Matthias Kaehlcke > --- > Documentation/devicetree/bindings/sound/dmic.txt | 2 ++ Reviewed-by: Rob Herring > sound/soc/codecs/dmic.c | 24 +++++++++++++++++++++++- > 2 files changed, 25 insertions(+), 1 deletion(-)