Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933745AbeAIH3W (ORCPT + 1 other); Tue, 9 Jan 2018 02:29:22 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43760 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756258AbeAIH3U (ORCPT ); Tue, 9 Jan 2018 02:29:20 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0C5DF6079C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: AceLan Kao , Larry.Finger@lwfinger.net Cc: QCA ath9k Development , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath9k: add a quirk to set use_msi automatically References: <1515461962-27129-1-git-send-email-acelan.kao@canonical.com> Date: Tue, 09 Jan 2018 09:29:14 +0200 In-Reply-To: <1515461962-27129-1-git-send-email-acelan.kao@canonical.com> (AceLan Kao's message of "Tue, 9 Jan 2018 09:39:22 +0800") Message-ID: <877esr32yd.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: AceLan Kao writes: > Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI > for WLAN device. So adding a quirk to list those machines and set > use_msi automatically. > Adding the following platforms to the quirk. > Dell Inspiron 24-3460 > Dell Inspiron 3472 > Dell Inspiron 14-3473 > Dell Vostro 3262 > Dell Vostro 15-3572 > > Signed-off-by: AceLan Kao [...] > @@ -96,6 +97,56 @@ static const struct ieee80211_tpt_blink ath9k_tpt_blink[] = { > }; > #endif > > +static int __init set_use_msi(const struct dmi_system_id *dmi) > +{ > + ath9k_use_msi = 1; > + return 1; > +} > + > +static const struct dmi_system_id ath9k_quirks[] __initconst = { > + { > + .callback = set_use_msi, > + .ident = "Dell Inspiron 24-3460", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 24-3460"), > + }, > + }, Larry, didn't rtlwifi have similar situation that with certain laptops users were required to enable a module parameter to get the device working? I think rtlwifi should do the same as AceLan does here as then the user would not need to manually set the module parameter. -- Kalle Valo