Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751279AbeAIJPB (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 9 Jan 2018 04:15:01 -0500
Received: from aserp2130.oracle.com ([141.146.126.79]:40458 "EHLO
        aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751658AbeAIJO5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Jan 2018 04:14:57 -0500
Date: Tue, 9 Jan 2018 12:14:28 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: Zeng Tao <prime.zeng@hisilicon.com>, labbott@redhat.com,
        sumit.semwal@linaro.org, gregkh@linuxfoundation.org,
        arve@android.com, tkjos@android.com, maco@android.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting
Message-ID: <20180109091428.sewxoc7vrtox33ai@mwanda>
References: <1515494623-8383-1-git-send-email-prime.zeng@hisilicon.com>
 <5A543741.9060806@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5A543741.9060806@hisilicon.com>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8768 signatures=668652
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=680
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.0.1-1711220000 definitions=main-1801090130
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Tue, Jan 09, 2018 at 11:30:09AM +0800, Chen Feng wrote:
> 
> 
> On 2018/1/9 18:43, Zeng Tao wrote:
> > This issue is introduced by the commit <e7f63771b60e> ("ION: Sys_heap:
> > Add cached pool to spead up cached buffer alloc"),

Use the Fixes tag.

Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")

> the gfp_mask low
> > order pool is overlapped by the high order inside the loop, so the
> > gfp_mask of all pools are set to high_order_gfp_flags.
> > 
> 
> Thanks
> > Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
> > ---
> >  drivers/staging/android/ion/ion_system_heap.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> > index 4dc5d7a..b6386be 100644
> > --- a/drivers/staging/android/ion/ion_system_heap.c
> > +++ b/drivers/staging/android/ion/ion_system_heap.c
> > @@ -298,10 +298,10 @@ static int ion_system_heap_create_pools(struct ion_page_pool **pools,
> >  					bool cached)
> >  {
> >  	int i;
> > -	gfp_t gfp_flags = low_order_gfp_flags;
> >  
> >  	for (i = 0; i < NUM_ORDERS; i++) {
> >  		struct ion_page_pool *pool;
> > +		gfp_t gfp_flags = low_order_gfp_flags;
> 
> Not define here. Better "gfp_flags = low_order_gfp_flags"

Either way is fine...

regards,
dan carpenter